In Class ViewExecutable Rename Views properties to core standards

+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.php
@@ -2050,7 +2036,7 @@ public function getItem($display_id, $type, $id) {
-    $this->element =& $element;
+    $this->element = & $element;

this is wrong.

Need to get the dependencies in other files too. For example there are some in core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php.

grep for each function name that was changed, there is probably more.

All places that use the properties from this class need to be updated. If they are covered by other issues, they should be rolled into this issue. But, this issue cannot be committed independently.

#2052421: [META] Rename Views properties to core standards has been postponed

The parent is not longer postponed

Working on this at Drupal Developer Days Lisbon

Please review.
I could not make an interdiff file as the old patch does not apply properly.

You can do that using patchutils interdiff.

Added an interdiff and a new patch that should solve the remaining/failing test.

Re-roll patch created for 9.1.x, Please review.

Fixed Test, Please review.

Fixed More Tests, Please review.

Fixed more tests, Please review.

Last patch is failed to apply , kindly review a patch.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

hey,
I will work on this issue.

Patch created for 10.1.x.
Kindly review.

Fixed the issues.
Kindly review

Trying to fix all the errors coming in patch on #50

Thanks everyone for all the interest.

Okay the file sizes go from

307
36
112
151
106

With no explanation why. What happened to the bulk of the changes in #40? Were they already completed? Module removed? This should be documented.

Am removing credit for bad rerolls as it's expected to check your code before uploading. You can check for build errors make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel...

Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.

Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not apply

To receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines for more information.

Tagging for issue summary for the open questions

This is a coding standards issue, tagging as such. Coding standard

In order to fix core coding standards in a maintainable way, all our coding standards issues are done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. If you are interested in working on coding standards issues, go to #3319843: [Meta] Fix coding standards in core and select an existing issue.

@akshaydalvi212, @adeshsharma and @Aadhar_Gupta, Thanks for the interest in improving Drupal coding standards! I have looked at the patches and as we can see from the test results, there are multiple errors. For the failing the pre commit checks see Run core development checks locally before submitting a change. This will avoid noise on the issue and allow us to focus on what is being fixed. I also recommend reading the Drupal Contributor Guide as recommended in #46.

Assigning to myself.

This is a coding standard fix and they are now done by sniff, not file. See #3346468: [meta] Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName