Needs review
Project:
Display Suite
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Aug 2013 at 12:21 UTC
Updated:
4 May 2016 at 14:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
aspilicious commentedShould be hidden on other templates
Comment #2
aspilicious commentedAnd you shouldn't insert html in a description...
Comment #3
aspilicious commentedSecond try
Comment #4
billiaug commentedDepending on the design, we want to add a wrapper around our complete field or just want to add an extra HTML element.
Mostly we can fix design related problems by using the :after or :before pseudo-elements, but in some cases we need more.
For example: we want to add a complete wrapper, add the element with an ".icon-smiley" class and add the "data-artist" attribute.
Before:
After:
Comment #5
aspilicious commentedNeeds discussion
Comment #6
Angry Dan commentedCross referencing my patch on previous duplicate issue "add prefix and suffix to expert field template" https://drupal.org/files/ds.field-ui.1529730-5.patch as part of the discussion.
Comment #7
aspilicious commentedFixed, needs porting
Comment #8
froboyThis was committed http://cgit.drupalcode.org/ds/commit/?id=f9a2714. There doesn't seem to be any reason to leave the issue open unless I'm missing something.
Comment #9
arh1 commentedIs there a reason I'm not considering that we're rendering the prefix inside the outer wrapper, and suffix outside of it? That seems problematic as the common use case of wrapping markup around the entire field output won't work as expected.
Comment #10
arh1 commentedHere's a quick patch to move the prefix outside of the field's outer wrapper, like the suffix, if that's indeed desirable.
Comment #11
aspilicious commentedThere is an issue with the suffix, will have to move that one inside the outer wrapper.
Comment #12
thomas.d commentedAdded a patch that moved the suffix inside the outer wrapper.
Comment #13
thomas.d commentedComment #14
aspilicious commentedThis can potentially break a lot of websites that rely on the current behaviour.
So I'm afraid I can't push this at the moment.