Add changed time tracking to users

We're not working on this right now.

user-changed-timestamp.patch queued for re-testing.

Updating the rerolled patch.

Please review.

This patch fixes the changed time tracking.

#11: Thanks! Please provide an interdiff next time though :)

1. +++ b/core/modules/user/lib/Drupal/user/Entity/User.php
   @@ -114,6 +114,9 @@ public function preSave(EntityStorageInterface $storage) {
   +
   +    // Before saving the user, set changed time.
   +    $this->changed->value = REQUEST_TIME;
   

   This is no longer necessary. You call FieldDefinition::create('changed'), which creates a field of the type changed. If you look at the corresponding ChangedItem (introduced in 533ee3a17f7ee2aa310ea1a1146a13e6c8201482
   http://drupalcode.org/project/drupal.git/commitdiff/533ee3a17f7ee2aa310ea1a1146a13e6c8201482">533ee3a17f7ee2aa310ea1a1146a13e6c8201482), you'll see that this is already done automatically there for you :)

2. +++ b/core/modules/user/lib/Drupal/user/Entity/User.php
   @@ -529,6 +539,10 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
   +      $fields['changed'] = FieldDefinition::create('changed')
   +          ->setLabel(t('Changed'))
   +          ->setDescription(t('The time the user was most recently saved.'));
   

   The first line is indented too much by two spaces, the second level by four.

3. +++ b/core/modules/user/lib/Drupal/user/UserInterface.php
   @@ -179,4 +179,11 @@ public function block();
   +  /**
   +   * Returns the user modification timestamp.
   +   *
   +   * @return int
   +   *   User modification timestamp.
   +   */
   +  public function getChangedTime();
   

   This should go away, UserInterface should simply extend EntityChangedInterface.

   Look at NodeInterface for an example :)

I just realized Views support is also necessary, but you can find a great example at #2074229: Add changed time tracking to taxonomy terms :)

Re-factored the patch based on review by @Wim Leers.

Now with 100% more required methods, hopefully this pleases the testbot.

18: 2074255-18.patch queued for re-testing.

Updating for Austin sprints. See http://www.hook42.com/blog/prepping-drupalcon-austin-sprints-sprint-lead...

+++ b/core/modules/user/user.install
@@ -123,6 +123,12 @@ function user_schema() {
+      'changed' => array(
+        'description' => 'The Unix timestamp when the user was most recently saved.',
+        'type' => 'int',
+        'not null' => TRUE,
+        'default' => 0,
+      ),

This hunk can be removed now, due to #2183231: Make ContentEntityDatabaseStorage generate static database schemas for content entities.

On an unrelated note: see also #2209971: Automatically provide a changed field definition.

I am manually testing this patch and I noticed a few things:

The changeddatabase column is created and is in fact updated when a user is saved, so that is good.

+++ b/core/modules/user/src/Entity/User.php
@@ -528,6 +535,10 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
+    $fields['changed'] = FieldDefinition::create('changed')
+      ->setLabel(t('Changed'))
+      ->setDescription(t('The time that the user was last edited.'));
+

The changed field definition should be moved up to be right after the created field to match the pattern in the node entity.

The next task is to write tests.

18: 2074255-18.patch queued for re-testing.

Rerolled patch as it failed to apply.
Moved up the field changed on entity definition.

Still left to write the tests.

Fixes a whitespace error and checking the test status.

Tests the "changed" and "created" timestamps. I'd like to also add a views test before this is committed.

#2074229: Add changed time tracking to taxonomy terms, on which the views integration in this patch is based, doesn't add any additional views tests, so I'd say this is ready for final review.

Looks great to me. Added a "updated date" column to the default user_admin_people view in Standard. Works fine. Analogous to Term and taxonomy.views.inc.

#35 Just because one patch does not add a test doesn't really mean that we should not here. I think we should at least have one test that shows that the changed field is available and usable by views.

Adds a views tests.

Rerolling!

rerolled path 39 patch.

As of #43, there is a "UserCreateTest", "UserEditTest", "UserChangedTest", and a test view. Is the "Needs tests" tag still applicable?

Reroll of FieldDefinition to BaseFieldDefinition.

Oh, here are the indents.

Committed 2acb1fd and pushed to 8.0.x. Thanks!