Part of meta-issue #2052421: [META] Rename Views properties to core standards

CommentFileSizeAuthor
#45 2066451-45.patch6.21 KBankit_rathore
#44 2066451-nr-bot.txt144 bytesneeds-review-queue-bot
#38 2066451-38.patch5.83 KBHardik_Patel_12
#31 2066451-31.patch5.68 KBanmolgoyal74
#29 2066451-29.patch5.06 KBanmolgoyal74
#18 drupal-rename_views_properties-2066451-18.patch5.09 KBtrzcinski.t@gmail.com
#15 drupal-rename_views_properties-2066451-15.patch5.09 KBalimac
#11 drupal-rename_views_properties-2066451-11.patch5.02 KBohthehugemanatee
#10 drupal-rename_views_properties-2066451-10.patch5.06 KBmpv
#9 drupal-rename-views-properties-in-filterpluginbase-2066451-9.patch4.9 KBInternetDevels
#5 rename-properties-2066451-4.patch9.29 KBjlindsey15
#4 rename-properties-2066451-4.patch9.29 KBjlindsey15
#2 rename-properties-2066451-2.patch5.75 KBjlindsey15
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jlindsey15’s picture

jlindsey15 CreditAttribution: jlindsey15 commented
Assigned: Unassigned » jlindsey15
jlindsey15’s picture

jlindsey15 CreditAttribution: jlindsey15 commented
Status: Active » Needs review
FileSize
rename-properties-2066451-2.patch5.75 KB

Status: Needs review » Needs work

The last submitted patch, rename-properties-2066451-2.patch, failed testing.

jlindsey15’s picture

jlindsey15 CreditAttribution: jlindsey15 commented
Status: Needs work » Needs review
FileSize
rename-properties-2066451-4.patch9.29 KB

Hmm I guess I have to change it in all the subclasses too...

jlindsey15’s picture

jlindsey15 CreditAttribution: jlindsey15 commented
FileSize
rename-properties-2066451-4.patch9.29 KB

Hmm I guess I have to change it in all the subclasses too...
EDIT: Sorry about the double post, not sure why that happened.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/modules/search/lib/Drupal/search/Plugin/views/filter/Search.php
@@ -20,7 +20,7 @@
-  var $always_multiple = TRUE;
+  var $alwaysMultiple = TRUE;

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php
@@ -54,25 +54,25 @@
-  var $always_required = FALSE;
+  var $alwaysRequired = FALSE;

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php
@@ -21,7 +21,7 @@
-  var $always_multiple = TRUE;
+  var $alwaysMultiple = TRUE;

This also should be protected/public ....

It feels odd that the uses of these variables aren't changed.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

.

id.medion’s picture

id.medion
Primary language Ukrainian
Location Lutsk
CreditAttribution: id.medion commented
Assigned: jlindsey15 » Unassigned
Issue summary: View changes
Issue tags: +Needs reroll
InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
drupal-rename-views-properties-in-filterpluginbase-2066451-9.patch4.9 KB

Rerolled patch for FilterPluginBase, other changes will be implemented in related issues.

mpv’s picture

mpv CreditAttribution: mpv commented
FileSize
drupal-rename_views_properties-2066451-10.patch5.06 KB

Rerolled this patch for latest HEAD.

ohthehugemanatee’s picture

ohthehugemanatee CreditAttribution: ohthehugemanatee commented
FileSize
drupal-rename_views_properties-2066451-11.patch5.02 KB

Rerolled for latest HEAD. @dawehner can we get a review?

Status: Needs review » Needs work

The last submitted patch, 11: drupal-rename_views_properties-2066451-11.patch, failed testing.

Status: Needs work » Needs review

mrjmd queued 11: drupal-rename_views_properties-2066451-11.patch for re-testing.

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies. Tagging for reroll.

alimac’s picture

alimac CreditAttribution: alimac commented
Issue tags: -Needs reroll +Amsterdam2014
FileSize
drupal-rename_views_properties-2066451-15.patch5.09 KB

Rerolled, and added reference from #2183415: In BooleanOperator Rename Views properties to core standards which also makes changes to FilterPluginBase.

alimac’s picture

alimac CreditAttribution: alimac commented
Status: Needs work » Needs review
trzcinski.t@gmail.com’s picture

trzcinski.t@gmail.com CreditAttribution: trzcinski.t@gmail.com commented
Issue tags: +Needs reroll

Hi,

this patch no longer applies. I am tagging with Needs reroll and start doing reroll.

trzcinski.t@gmail.com’s picture

trzcinski.t@gmail.com CreditAttribution: trzcinski.t@gmail.com commented
FileSize
drupal-rename_views_properties-2066451-18.patch5.09 KB

Attaching the rerolled patch. It applies for the latest dev currently.

trzcinski.t@gmail.com’s picture

trzcinski.t@gmail.com CreditAttribution: trzcinski.t@gmail.com commented
Issue tags: -Needs reroll

Removing Needs reroll tag. Sorry - I forgot in the first post.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Needs review » Postponed
Parent issue: » #2052421: [META] Rename Views properties to core standards

#2052421: [META] Rename Views properties to core standards has been postponed.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tobiberlin’s picture

tobiberlin
Primary language German
Location Berlin, Germany
CreditAttribution: tobiberlin commented
Issue tags: +Vienna2017

I am a first time sprinter on Vienna 2017 and will work on this know...

tobiberlin’s picture

tobiberlin
Primary language German
Location Berlin, Germany
CreditAttribution: tobiberlin commented
Issue tags: -Vienna2017

I was told not to work on this issue so I am stopping

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Postponed » Needs work

The parent is not longer postponed

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2066451-29.patch5.06 KB

Status: Needs review » Needs work

The last submitted patch, 29: 2066451-29.patch, failed testing. View results

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2066451-31.patch5.68 KB

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented

The same patch #31 works fine with 8.7.x

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3034944: Fix docblocks in Views filter plugins

There's better cleaned patch in duplicated issue

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commented
FileSize
2066451-38.patch5.83 KB

Patch for 9.1.x branch , kindly review.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commented
Status: Needs review » Needs work
FileSize
2066451-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

ankit_rathore’s picture

ankit_rathore CreditAttribution: ankit_rathore at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2066451-45.patch6.21 KB

Re-rolled patch #38 against 10.1.x-dev
Please review it.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs review » Postponed

This is a coding standard fix and they are now done by sniff, not file. See #3346468: [meta] Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.