Split webform_node_types as content type specific.

Hi @hswong3i, thanks for the patch!

I think splitting up the variable into separate ones is a good idea. It makes it easier to manage via features this way. However, I'm on the fence about putting the Webform-enabled setting on the individual content type forms, as I mentioned in this very similar issue: #1963870: Expose Webform settings in content type form .

Instead of having two issues for the same thing, could you review that patch and merge in your different changes (if any) into it?

@hswong3i: Your second patch file contains distinct consecutive diffs. That makes it unnecessary difficult to follow the changes.

I generally agree with the ideas presented on this issue, I'll review the patch as soon as I can (no sooner).

While testing this out I found a significant flaw in the update hook:

$types = array_keys(array_filter(variable_get('webform_node_types', array('webform')))

This will always produce a non-sensical array that uses the numeric keys as the values. i.e. array(0, 1, 2). I think it should just be:

$types = variable_get('webform_node_types', array('webform'));

This patch updates the update hook and makes the Vertical Tabs integration a little more explicit. It now says "Disabled" if the checkbox for enabling Webform isn't enabled.

One more change. I made webform_node_types() return an unkeyed array, rather than keying by content type. That makes it consistent with the previous variable by the same name. $key => $key arrays always seem unnecessary to me.

@quicksketch: seems missed out the js/node-type-form.js from #10?

Ah, yes most likely. I made some changes to that file too. I'll reroll tomorrow.

Add related project patch links

I'll reroll tomorrow.

Well I'll reroll it soon at least. :P

Here's the patch with the node-type-form.js file included.

Well, even though I'm not particularly a fan of this approach, an informal survey of my peers resulted in everyone thinking it made sense to move the settings. I can't find any problems with the patch and everything works for me, so I've committed it to the 7.x-4.x branch.