Split linkchecker_scan_nodetypes as content type specific

That sounds very useful. Where have you moved the batch scan that fires if you enabled a content type for scanning?

But we need to fire it. Beginners will not understand it and I also do not like to scan manually, too. This must be changed.

+++ b/linkchecker.moduleundefined
@@ -950,6 +950,49 @@ function linkchecker_form_alter(&$form, &$form_state, $form_id) {
+  if ($linkchecker_scan_node > variable_get('linkchecker_scan_node_' . $type)) {

Why has variable_get() no default? That may be a problem if it has never set.

I guess we also need to add a hook_node_type_delete() to delete the variable or we have stale variables as node_type_get_names() in hook_uninstall() will not return deleted node types.

Aside, why not using hook_node_type_insert/update() for the batch? May be easier than the submit handler.

+++ b/linkchecker.moduleundefined
@@ -950,6 +950,49 @@ function linkchecker_form_alter(&$form, &$form_state, $form_id) {
+    // Add the submit handler to fire the batch scan if enabled a content type
+    //for scanning.
+    $form += array('#submit' => array());
+    if (!in_array('linkchecker_form_node_type_form_submit', $form['#submit'])) {
+      array_unshift($form['#submit'], 'linkchecker_form_node_type_form_submit');
+    }
+  }
+}
+
+/**
+ * Custom submit handler for node type form.
+ */
+function linkchecker_form_node_type_form_submit($form, &$form_state) {
+  $type = $form_state['values']['type'];
+  $linkchecker_scan_node = $form_state['values']['linkchecker_scan_node'];
+
+  if ($linkchecker_scan_node > variable_get('linkchecker_scan_node_' . $type)) {
+    module_load_include('inc', 'linkchecker', 'linkchecker.batch');
+    batch_set(_linkchecker_batch_import_nodes(array($type)));
+  }
+
+  variable_set('linkchecker_scan_node_' . $type, $linkchecker_scan_node);

No longer needed, isn't it?

+++ b/linkchecker.moduleundefined
@@ -817,6 +817,33 @@ function _linkchecker_status_handling(&$response, $link) {
+ * Implements hook_node_type_insert().
+ */
+function linkchecker_node_type_insert($info) {
+  if (variable_get('linkchecker_scan_node_' . $info->type, FALSE)) {
+    module_load_include('inc', 'linkchecker', 'linkchecker.batch');
+    batch_set(_linkchecker_batch_import_nodes(array($info->type)));
+  }
+}
+
+/**
+ * Implements hook_node_type_update().
+ */
+function linkchecker_node_type_update($info) {
+  if (variable_get('linkchecker_scan_node_' . $info->type, FALSE)) {
+    module_load_include('inc', 'linkchecker', 'linkchecker.batch');
+    batch_set(_linkchecker_batch_import_nodes(array($info->type)));
+  }
+}

Let's try not duplicating code. Just call the update function from the insert. Aside - calling it on insert makes not so much sense as there is no content yet... I believe we can remove the insert completely. and we should not re-run it with every update. Only if the setting has been changed to enabled.

+++ b/linkchecker.moduleundefined
@@ -965,32 +992,10 @@ function linkchecker_form_node_type_form_alter(&$form, $form_state) {
-
-    // Add the submit handler to fire the batch scan if enabled a content type
-    //for scanning.
-    $form += array('#submit' => array());
-    if (!in_array('linkchecker_form_node_type_form_submit', $form['#submit'])) {
-      array_unshift($form['#submit'], 'linkchecker_form_node_type_form_submit');
-    }
   }
 }
 
 /**
- * Custom submit handler for node type form.
- */
-function linkchecker_form_node_type_form_submit($form, &$form_state) {
-  $type = $form_state['values']['type'];
-  $linkchecker_scan_node = $form_state['values']['linkchecker_scan_node'];
-
-  if ($linkchecker_scan_node > variable_get('linkchecker_scan_node_' . $type)) {
-    module_load_include('inc', 'linkchecker', 'linkchecker.batch');
-    batch_set(_linkchecker_batch_import_nodes(array($type)));
-  }
-
-  variable_set('linkchecker_scan_node_' . $type, $linkchecker_scan_node);
-}
-
-/**

?

variable_get('linkchecker_scan_node_' . $type, $linkchecker_scan_node); in update hook and compare with the form value and set it afterwards... aside the save of the variable seems missing in the node type update hook.

Why not moving the comment scan checkbox to the node type, too? So we have all settings together.

I believe keeping the settings splitted is a usability fail. It looks really confusing to me that one setting is inside content type and the other in linkchecker setting, but both are about the content type. Your patch is a good usability improvement for sure, but if we change this now, we should keep both together.

Please do not change Maintenance. A user should normally not use it. There are only rare exceptions.

Great patch. Thanks a lot for this. I'm missing the already discussed batch scan in the code once the _node_type_form_alter() form is submitted. Maybe I missed it, but it seems not there. If I remember correctly you had it inside in past!?

What do you think about static caching of the arrays in linkchecker_scan_node_types() and linkchecker_scan_comment_types()?

Changes:

• Added a note to changelog
• Renamed the JS file to linkchecker-node-form.js like comment-node-form.js
• Removed the weights from fields in hook_form_node_type_form_alter(). No idea what the reason for this was.
• Changed wording on some translatable strings.
• Added a 'Disabled' status to vertical bar if all checkboxes are disabled.
• Minor code style changes and additions.
• Moved the new help into general fieldset description.
• FIXED: linkchecker_modules_disabled() has a linkchecker_scan_comments leftover. This also shows that there is a problem if linkchecker_scan_comment_types() will always return data if the comment module is disabled. However we may need to add a module_exists('comment') check to linkchecker_scan_comment_types().

Bugs:

• A content type save does not fire a batch scan of the content type. This is required if the settings have been changed from disabled to enabled, otherwise not.

Add more reference links

@hswong3i: Are you able to finish the patch, please?

#20 was against latest dev.

There are lot of differences to mine.

Missed the new JS file in last patch

// Add custom submit handler to custom block delete form.
       $form['#submit'][] = 'linkchecker_block_custom_delete_form_submit';
       break;

has been removed. This is a new bug and not a cleanup.

The bug in #20 is not fixed.

Will you fix the remaining bugs or should be won't fix now?

Marking this critical to make sure this goes in soon and before we start porting to D8.

The patch does not apply.

+++ b/linkchecker.admin.inc
@@ -311,30 +291,6 @@
-
-  // Re-scan items, if node types or comment or custom block selection has been
-  // changed.
-  $additional_nodetypes_selected = array_diff($form_state['values']['linkchecker_scan_nodetypes'], $form['settings']['linkchecker_scan_nodetypes']['#default_value']);
-  if (!empty($additional_nodetypes_selected) || $form_state['values']['linkchecker_scan_comments'] > $form['settings']['linkchecker_scan_comments']['#default_value']) {
-    $node_types = array_keys(array_filter($form_state['values']['linkchecker_scan_nodetypes']));
-
-    // If one or more node types have been selected.
-    if (!empty($node_types)) {
-      module_load_include('inc', 'linkchecker', 'linkchecker.batch');
-      batch_set(_linkchecker_batch_import_nodes($node_types));
-
-      // If comment scanning of node types has been selected.
-      if ($form_state['values']['linkchecker_scan_comments'] > $form['settings']['linkchecker_scan_comments']['#default_value']) {
-        batch_set(_linkchecker_batch_import_comments($node_types));
-      }
-    }
-  }
-
-  // If block scanning has been selected.
-  if ($form_state['values']['linkchecker_scan_blocks'] > $form['settings']['linkchecker_scan_blocks']['#default_value']) {
-    module_load_include('inc', 'linkchecker', 'linkchecker.batch');
-    batch_set(_linkchecker_batch_import_block_custom());
-  }

This suxx so much. This part is missing in the patch.

Just confirming that #36 is all that remains here?

Yes, as I know.

thanks

So the approach here would be to just re scan when a content-type had its setting turned on?

Yes. If we do not scan the content type - only links from new content would be checked.

Added back block hunk, as that is unchanged.

Added in submit handler for node form to trigger batch scanning on the one node-type on submit.

And with support for old php versions