Remove calls to deprecated global $user in core/includes/bootstrap.inc

Issue #2062151: Create a current user service to ensure that current account is always available Fix.

#4: drupal8.base-system.2062069-4.patch queued for re-testing.

Updated patch to use: $user = Drupal::request()->attributes->get('_account');

Re-roll

Push for testing

Lets, try with removing request scope adding this patch #2076411: Remove the request scope from the current user service

Same as #14 but without the scope bit which was done elsewhere(temporarily)

#17: bootstrap-remove-global-user-from-bootstrap-inc-2062069-17.patch queued for re-testing.

This patch makes just one change. Let's see if it breaks the install.

Here's the error on the patch above #21:

WD php: Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "current_user", path: "current_user". in              [error]
Symfony\Component\DependencyInjection\Container->get() (line 283 of
/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Container.php).
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "current_user", path: "current_user". in Symfony\Component\DependencyInjection\Container->get() (line 283 of /core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Container.php).

  global $user;
  $config = \Drupal::config('system.date');

  if ($user && $config->get('timezone.user.configurable') && $user->isAuthenticated() && $user->getTimezone()) {

Let's have a look at this piece of code. $user is not required to let this be run. I think this behavior is intended as the installer
or other really early bootstrap code don't have a user yet. In order to use a service you can use \Drupal::getContainer()->get('current_user', \Symfony\Component\DependencyInjection\ContainerInterface::IGNORE_ON_INVALID_REFERENCE); which will not throw an exception.

Seems to be still failing locally with the same error, but thanks for giving more hints @dawehner

if (\Drupal::getContainer()->has('current_user')) {
 $user = \Drupal::getContainer()->get('current_user');
}

Oh right, this is indeed way simpler.

Still not working locally, so I expect the same results.

.

Yeah, well.

Unfortunately, our oh so great pluggable authentication system is a lie. Or to be specific, the Cookie authentication provider is a lie.

It simply calls drupal_session_initialize(), that then directly populates global $user and only global $user and directly calls date_default_timezone_set(drupal_get_user_timezone()); Obviously, in there, the user service is never going to be set.

What needs to happen is that this function is moved to the authentication manager, after we are able to populate the user service. But moving that will probably not work, because the reason the cookie stuff works like this is that this code is still shared with the installer/update/authenticate stuff.

Something needs to happen to session.inc. Something that involves fire. But #1858196: [meta] Leverage Symfony Session components isn't working either so far :(

I would love to knock the session issue out but need help. The frustrating thing is that I was hoping this issue would help as I'm trying to remove the use of the global user there to.

Regardless, I feel we are dramatically close to a solution with the session patch. Please help.

29: 2062069-29-global-user-bootstrap-simple.patch queued for re-testing.

Postponed on #1858196: [meta] Leverage Symfony Session components

See #2328645: Remove remaining global $user, closing as duplicate of that.