Porting to 8.x

Are you volunteering?

Mostly blocked by the issues listed in #1948588: Google Analytics 8 upgrade

Hello from Drupal's GSoC 2014 team. Google Summer of Code (GSoC)? - an annual program for university students organized by Google with projects managed by open source organization mentors such as us (Drupal!).

We're currently browsing the issue queue looking for projects. Do you think this issue/project is worth a student spending a summer on it and being paid by Google? If so, are you interested in mentoring the student? Learn more about Summer of Code and how to get involved at links below. We're submitting our Summer of Code application to Google in just over 24 hours and looking for last minute ideas. Please respond quickly if you're interested.

Group to join - https://groups.drupal.org/google-summer-code

Ideas for projects for Summer of Code 2014 - https://groups.drupal.org/node/404778

GSoC Homepage http://www.google-melange.com/gsoc/homepage/google/gsoc2014

Google's Summer of Code 2014 Announcement - http://google-opensource.blogspot.com/2014/02/mentoring-organization-app...

I belive this is a 4-6h job only. Not sure if this is useful for SOC. Link checker will be more advanced to upgrade.

I am tracking some code work on https://github.com/dawehner/piwik

I'm going to start looking at this, the github repo posted by @dawenhner looks like it's had a considerable amount of work so I'll start with that.

I've spent the day starting off with the github repo, and using the Google Analytcics 8.x-2.x branch as a guide to upgrade (as it looked like the github repo had also heavily borrowed from an earlier version of GA).

You can follow my progress at https://www.drupal.org/sandbox/zombienaute/2553569

See #6

I've made significant progress and have a working module in my sandbox, considering #6 is 2 years old I didn't think that would apply. In any case I'm going to finish the port in my sandbox so would be greatful if you could consider making me a maintainer so I can just contribute straight to this project.

I'm porting with GA in mind. It does not matter if the comment is 2 years old or not. The situation is still the same.

Not sure where you are porting from. As long as core breaks GA every 2-3 weeks I'm still waiting for stable core and #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!) may break it again and #2391029: Attaching inline JS no longer possible. Help get this back into core! may break a lot again.

@hass I started from the github repo at #7 and used the 8.x-2.x branch of GA as a guide to make it work. It's working now and I'm just finishing off getting the config schema finished (having some problems with the custom_var).

I invested quite a bit of time into this so would appreciate you taking a look at the sandbox and committing as an 8.x branch to this project, at least we would then have a starting point on d.o going forward. It is developed in pretty much the same fashion as the GA module.

Here's the patch, I'll stop work on this until I get confirmation that my work will be used.

Still TODO: Write Tests.

So, now that those issues above are closed, can you give me feedback on the patch so we can get this committed?

The patch seems not implement the changes made to GA. It lacks a lot of changes, removes php module support, tests and so on. I start from scratch.

Most coding should be done, but some tests are still failing.

Ok, cheers @hass I'll take a look at that when I get a chance. Unfortunately my Drupal contrib time is very limited at the moment.

http://cgit.drupalcode.org/piwik/tree/src/Tests/PiwikBasicTest.php?h=8.x... requires "/" path prefixing in tests.

The patch seems not implement the changes made to GA. It lacks a lot of changes, removes php module support, tests and so on. I start from scratch.

Totally fair point. I hope though you don't keep php module support. Its broken by design

Why is it broken by design? It still exists in contrib and we can just keep the few lines of code.

Can someone of you take a look and give me a hint what is wrong? I cannot catch invalid URLs. Both dawehners github and the patch here are not working.

We also need to fix the upgrade from D6/D7.

All is green, let's see if this patch it get's green, too.

Looks reasonable for me :)

Sorry, I'm unsure what's going on here. I spent a couple of days working on this port and can now see the 8.x-1.x version is live and I only have a single commit against my name to do with adding the composer file?