The upgrade only migrates the settings from previous GA versions, but do not fix the now invalid paths. This breaks path based visibility filtering.

CommentFileSizeAuthor
#11 Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch9.46 KBhass
#8 Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.83 KBhass
#7 Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.85 KBhass
#6 Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.85 KBhass
#4 Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.9 KBhass

Comments

hass’s picture

hass commented
Title: Write upgrade for 'google_analytics_pages' and prefix all paths with '/' » Write migration for 'google_analytics_pages' and prefix all paths with '/'
hass’s picture

hass commented
Title: Write migration for 'google_analytics_pages' and prefix all paths with '/' » Migrate 'google_analytics_pages' and prefix all paths with '/'
hass’s picture

hass commented
Related issues: +#2532550: Leading slashes not added to visibility paths
hass’s picture

hass commented
StatusFileSize
new Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.9 KB

A first try based on BlockVisibility.php and #2532550: Leading slashes not added to visibility paths. Fully untested and I have no idea how to write a Plugin.

hass’s picture

hass commented
Status: Active » Needs review
hass’s picture

hass commented
StatusFileSize
new Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.85 KB
hass’s picture

hass commented
StatusFileSize
new Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.85 KB
hass’s picture

hass commented
StatusFileSize
new Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch7.83 KB
hass’s picture

hass commented
Status: Needs review » Needs work

No idea how to fix this:

Recoverable fatal error: Argument 5 passed to Drupal\google_analytics\Plugin\migrate\process\GoogleAnalyticsVisibilityPages::__construct() must implement interface Drupal\migrate\Plugin\MigrateProcessInterface, instance of Drupal\Core\Extension\ModuleHandler given, called in drupal8\modules\google_analytics\src\Plugin\migrate\process\GoogleAnalyticsVisibilityPages.php on line 68 and defined in Drupal\google_analytics\Plugin\migrate\process\GoogleAnalyticsVisibilityPages->__construct() (line 51 of drupal8\modules\google_analytics\src\Plugin\migrate\process\GoogleAnalyticsVisibilityPages.php).
hass’s picture

hass commented
Related issues: +#2408165: Migration Files for Drupal 7 Blocks

Adding the committed patch reference

hass’s picture

hass commented
StatusFileSize
new Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch9.46 KB

.

The last submitted patch, 4: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 4: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 4: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 4: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 4: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review

The last submitted patch, 6: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 6: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 6: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 6: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 6: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 7: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 7: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 7: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 7: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 7: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 8: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 8: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 8: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 8: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

The last submitted patch, 8: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 11: Issue-2531648-by-hass-Migrate-googleanalyticspages-a.patch, failed testing.

  • hass committed f2ec305 on 8.x-2.x 
    Issue #2531648 by hass: Migrate 'googleanalytics_pages' and prefix all...

  • hass committed a20e766 on 
    Issue #2531648 by hass: Fix failing roles migration
hass’s picture

hass commented
Title: Migrate 'google_analytics_pages' and prefix all paths with '/' » Migrate 'pages' and 'roles' settings to D8
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Related issues: +#2906878: [Meta] Support for D7 -> D9 contrib migrate

Linking in #2906878: [Meta] Support for D7 -> D9 contrib migrate