Twitter module is not writing tweets to DB

Hi,

I had the same problem in one of our D6 installations.

I have fixed the problem with this patch.

Hope it helps.

Cheers!

if this is a bug I think should be reviewed.

At least major I think.

Triggering the testbot.

Triggering the testbot.

Correct me if I'm wrong but are we sure about this? Tested both 7.x-5.x and 6.x-5.x code is identical then it a point was backported from 7.x to 6.x, on clean Drupal installations with 3 twitter accounts. Two auth. and one not.

SELECT twitter_id, created_time FROM twitter;
+--------------------+--------------+
| twitter_id         | created_time |
+--------------------+--------------+
| 550426976843231234 |   1420066992 |
| 550654077013860352 |   1420121137 |
| 550778068286308352 |   1420150699 |
| 550944181766860800 |   1420190303 |
| 550998686072045568 |   1420203298 |
| 551003018100228096 |   1420204331 |
| 551730771086819329 |   1420377841 |
| 551731229415186434 |   1420377950 |
| 551734633067716609 |   1420378761 |
| 551735201723080704 |   1420378897 |
| 551736513298714624 |   1420379210 |
| 551740682839556096 |   1420380204 |
| 551762642407530496 |   1420385439 |
| 552011639177093120 |   1420444805 |
| 552080039639269376 |   1420461113 |
| 552140988744228864 |   1420475644 |
| 552383168809279488 |   1420533384 |
| 552415056282267649 |   1420540987 |
| 552418036544978944 |   1420541698 |
| 552422931339689986 |   1420542865 |
+--------------------+--------------+
20 rows in set (0.00 sec)

How do we actually reproduce this problem?

I agree I'm confused about the code in twitter_fetch_user_timeline(). Calling twitter_connect() with no id only result in the same (first authenticated account) account get called for each twitter account found by the module. I have no idea why it still work?

Lets try this. Ported to 7.x-6.x.

Ported to 7.x-5.x.

Ported to 6.x-5.x.

I've read through the code. There are a few possible scenarios for the $account to not be able to access the twitter $id's timeline. So this update checks if the $account is authenticated, if so it is used, otherwise it uses the first authenticated account that could be found.

Ported to 7.x-5.x.

Ported to 6.x-5.x again.

Rerolled for 7.x-5.x.

Rerolled again, better this time.

Rerolled for 7.x-6.x.

Backported to 6.x-5.x.

Fyi: had to do some bot maintenance the d7 patch may not properly test, and may need a retest.

@Mixologic: Thanks for letting me know, we'll see how the latest patches work out.

Committed.