Task to add additional test coverage for the various classes in \Drupal\Component\Plugin. Also, the current tests are in the core directory, which may mean they are intertwined with core overrides. These should be split into separate tests if that is the case.

See #1938068: Convert UnitTestBase to PHPUnit.

Current issues:

Drupal\Component\Plugin\Context\Context gets its own section, due to needing a little refactoring and bug-fixing.

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Before we do this, we should convert the existing tests to PHPUnit I think. That will increase the test coverage already, by a lot. There is also a bunch of classes that aren't touched at all yet, so the actual coverage of that component is much lower ;)

The test conversion however, is going to be blocked by a bunch of things.. Non-injected decorators like Cache (which is being replaced with the default plugin manager) and a very fun one: @Translation, which calls t(). Maybe that can call the service now and we can do some tricks with injection a container into Drupal...

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Parent issue: » #1938068: Convert UnitTestBase to PHPUnit
yesct’s picture

yesct commented

#1938068: Convert UnitTestBase to PHPUnit is fixed now.
we can come back to this to see what needs to be done.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

I thought I'd start on this.

I ended up testing Drupal\Core\Plugin by accident. :-)

Here's the issue: #2368019: Expand unit testing for Drupal\Core\Plugin\Context\ContextDefinition

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Related issues: +#2368585: Expand unit testing for Drupal\Component\Plugin\ContextAwarePluginBase

Here's one in the proper namespace: #2368585: Expand unit testing for Drupal\Component\Plugin\ContextAwarePluginBase

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Again with the tests! #2370183: Expand unit testing for Drupal\Component\Plugin\Discovery\DiscoveryTrait

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

And... #2371531: Expand unit testing for Drupal\Component\Plugin\PluginManagerBase

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Expand phpunit tests for \Drupal\Component\Plugin classes » [meta] Expand phpunit tests for \Drupal\Component\Plugin classes
Issue summary: View changes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes

The hits just keep on coming. #2375737: Expand unit testing for Drupal\Component\Plugin\Factory\ReflectionFactory

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes

Found a bug. #2380029: Drupal\Component\Plugin\Derivative\DeriverBase is designed to error out.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

I ran all the tests except the last one and made comments mainly about coding standards because the code seemed good to me.
Good job @Mile23!

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
commented
Component: base system » plugin system

.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented

Is this one still relevant?

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.