Theme Seven has "Demonstrate block regions" broken

This bug seems to have been fixed elsewhere however we should still try get this test in.

#1: core-2042879-demonstrate-block-regions-test.patch queued for re-testing.

However, the exit link is currently broken which this test should also catch: see #2056887: Exit block region demonstration link is broken.

#1: core-2042879-demonstrate-block-regions-test.patch queued for re-testing.

Namespaces have changed, so at a minimum #1 needs a reroll for that.

I can't reproduce this bug, I follow the steps and no error.

I think the remaining effort here was to get the test in, so the bug doesn't get reintroduced.

Worked on this but wasn't seeing it come into my testing list page, is there some autoloader trick? Maybe someone can help spot the issue.
Patch attached.

Maybe testbot will pick it up?

Nope, not sure what I am missing.

1. +++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
   @@ -0,0 +1,68 @@
   + * Tests the Demonstrate block regions functionality.
   + */
   +class BlockDemonstrateRegionsTest extends WebTestBase {
   

   This should have @group block after a blank line, see \Drupal\block\Tests\BlockTest for an example.
   This is why it's not getting picked up.

2. +++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
   @@ -0,0 +1,68 @@
   +  /**
   +   * An administrative user to configure the test environment.
   +   */
   +  protected $adminUser;
   ...
   +    $this->adminUser = $this->drupalCreateUser(array(
   +      'administer blocks',
   +      'access administration pages',
   +    ));
   +    $this->drupalLogin($this->adminUser);
   

   You don't need a property for this, or even a variable. $this->drupalLogin($this->drupalCreateUser(....)); should be enough.

3. +++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
   @@ -0,0 +1,68 @@
   +  public static function getInfo() {
   +    return array(
   +      'name' => 'Block Demonstrate block regions',
   +      'description' => 'Tests functionality of "Demonstrate block regions".',
   +      'group' => 'Block',
   +    );
   +  }
   

   This can be removed.

4. +++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
   @@ -0,0 +1,68 @@
   +
   +  function setUp() {
   +    parent::setUp();
   

   This should have {@inheritdoc} as a docblock

5. +++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
   @@ -0,0 +1,68 @@
   +  function setUp() {
   ...
   +  function testDemonstrateSeven() {
   

   protected function setUp
   public function testDemonstrateSeven

6. +++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
   @@ -0,0 +1,68 @@
   +   * Test Demonstrate block admin page exists and functions correctly.
   

   Tests 'Demonstrate block regions' page exists and functions correctly.

Finally, since this is a new file it'd be nice to use [] instead of array() in all occurrences.

Thanks @tim.plunkett.

Reroll based on #15.

Looks like \Drupal::service('theme_handler')->enable() changed to \Drupal::service('theme_handler')->install().

This might be a bug in \Drupal\simpletest\WebTestBase::clickLink()

I'm getting an odd error "Link Demonstrate block regions (Seven) does not exist on http://drupal8_2.dev/admin/structure/block/list/seven" while testing. Even though the link is definitely there and the text matches exactly.

Help module needs to be enabled & the help block's system name is help_block.

Also, as suggested in #15 removed:

+++ b/core/modules/block/src/Tests/BlockDemonstrateRegionsTest.php
@@ -0,0 +1,68 @@
+  public static function getInfo() {
+    return array(
+      'name' => 'Block Demonstrate block regions',
+      'description' => 'Tests functionality of "Demonstrate block regions".',
+      'group' => 'Block',
+    );
+  }

Followed the steps to reproduce the issue, but the error is not displayed.The issue is not reproducible

I agree @Truptti. I can't reproduce this issue.

I vote for "Close (cannot reproduce)".

As per #21 and #22