Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
On clean drupal 8 installation
- go to Structure > Blocks (admin/structure/block)
- click on Seven tab (admin/structure/block/list/block_plugin_ui%253Aseven)
- click on "Demonstrate block regions (Seven)" (admin/structure/block/demo/seven)
get page with very small content
after clicking on 'Exit block region demonstration' (admin/structure/block/list/seven)
get a 'Page not found' error
Originally reported https://drupal.org/node/1987636#comment-7594383
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-16-19.txt | 1.41 KB | siva_epari |
#19 | theme_seven_has-2042879-19.patch | 1.68 KB | siva_epari |
#16 | theme_seven_has-2042879-16.patch | 1.87 KB | kerby70 |
#12 | interdiff-2042879-1-12.txt | 3.66 KB | kerby70 |
#12 | theme_seven_has-2042879-12.patch | 1.98 KB | kerby70 |
Comments
Comment #1
ygerasimov CreditAttribution: ygerasimov commentedAttaching patch with test showing the error. It should fail.
Comment #3
benjy CreditAttribution: benjy commentedThis bug seems to have been fixed elsewhere however we should still try get this test in.
Comment #4
benjy CreditAttribution: benjy commented#1: core-2042879-demonstrate-block-regions-test.patch queued for re-testing.
Comment #5
benjy CreditAttribution: benjy commentedHowever, the exit link is currently broken which this test should also catch: see #2056887: Exit block region demonstration link is broken.
Comment #7
tim.plunkett#1: core-2042879-demonstrate-block-regions-test.patch queued for re-testing.
Comment #9
jhedstromNamespaces have changed, so at a minimum #1 needs a reroll for that.
Comment #10
rpayanmI can't reproduce this bug, I follow the steps and no error.
Comment #11
jhedstromI think the remaining effort here was to get the test in, so the bug doesn't get reintroduced.
Comment #12
kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commentedWorked on this but wasn't seeing it come into my testing list page, is there some autoloader trick? Maybe someone can help spot the issue.
Patch attached.
Comment #13
kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commentedMaybe testbot will pick it up?
Comment #14
kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commentedNope, not sure what I am missing.
Comment #15
tim.plunkettThis should have
@group block
after a blank line, see \Drupal\block\Tests\BlockTest for an example.This is why it's not getting picked up.
You don't need a property for this, or even a variable.
$this->drupalLogin($this->drupalCreateUser(....));
should be enough.This can be removed.
This should have {@inheritdoc} as a docblock
protected function setUp
public function testDemonstrateSeven
Tests 'Demonstrate block regions' page exists and functions correctly.
Finally, since this is a new file it'd be nice to use [] instead of array() in all occurrences.
Comment #16
kerby70 CreditAttribution: kerby70 commentedThanks @tim.plunkett.
Reroll based on #15.
Looks like \Drupal::service('theme_handler')->enable() changed to \Drupal::service('theme_handler')->install().
This might be a bug in \Drupal\simpletest\WebTestBase::clickLink()
I'm getting an odd error "Link Demonstrate block regions (Seven) does not exist on http://drupal8_2.dev/admin/structure/block/list/seven" while testing. Even though the link is definitely there and the text matches exactly.
Comment #17
kerby70 CreditAttribution: kerby70 commentedComment #19
siva_epari CreditAttribution: siva_epari commentedHelp module needs to be enabled & the help block's system name is help_block.
Also, as suggested in #15 removed:
Comment #20
siva_epari CreditAttribution: siva_epari commentedComment #21
Truptti CreditAttribution: Truptti at Axelerant commentedFollowed the steps to reproduce the issue, but the error is not displayed.The issue is not reproducible
Comment #22
rpayanmI agree @Truptti. I can't reproduce this issue.
I vote for "Close (cannot reproduce)".
Comment #23
joelpittetAs per #21 and #22