Exposed Sort By and Sort Order view pane settings not retained

I stumbled across the same issue - we're using views panes and none of sorts would display saved values. I debugged it to views module, filters actually get wrong default values.

Here's patch (for latest 7.x-3.x) I created to solve this issue.

Somehow I lost the patch, here it is

changing status

RTBC +1!

We're using this patch in Panopoly. :-)

Just confirming that this is also working on my side.

Looks like a test bot hiccup. Putting back to RTC.

Detect a test run failure
Ensure that you can install SimpleTest locally and invoke tests using the command line script.

The patches in #2 fixes the issue and correctly applies on latest 3.11 release.

Updated #2 to check sort_order property before accessing it to avoid php notice spam. Default to original sort if the property is undefined.

patch #12 works for me.

Patch #12 fixes the issue and correctly applies on 3.11 release for me as well.

So I have been working on similar issues. I am running panopoly so this patch was already applied. But then I started seeing issues with the default "sort_by" & "sort order" not getting applied for exposed sorts.

I found the issue: https://www.drupal.org/node/666870 which is fairly old but for the most part the approach looked good to me over there. I took that patch applied it to this one in addition I fixed the issue where the default sort order wasn't getting applied.

This patch seems to be fixing all my issues.

If this patch is good we need to make sure to give credit for all those found in: https://www.drupal.org/node/666870

#16 Works like a charm.

Also, for the Panopoly folks, I added a patch here: #2782721: Exposed Views Sort Order Bug

Refactored #16 a bit to simplify and clarify the logic.

+++ b/plugins/views_plugin_exposed_form.inc
@@ -220,33 +220,46 @@ class views_plugin_exposed_form extends views_plugin {
+        if (isset($form_state['input']['sort_by'])) {

This is block of code is quite complex and would benefit with some comments to explain the logic?

Update patch due to #2920737: Tidy up tests, coding standards via latest 7.x-3.x-dev

Thanks
#26 patch work for me

Thanks hswong3i, #26 works like a charm on latest stable.

Here's a re-roll of #26 that applies to the latest release 3.25.

Still works. Setting back to RTBC, we've used this patch in production for 5+ years on hundreds of sites.

Committed. Thank you.