Bluez

Hi Ujval,

Manual Review:

At footer:
When i hover on power by drupal. i am not able to read Drupal due to it's hover color is black.
same issue is at Designed & Develop by Ujval Shah when i hover mouse on Ujval Shah it's not read able.

In slider.js file:
Remove one space at line 51 to 55.

Other wise themes looks good for me.

Thanks,
Mayank

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/css/style.css
  --------------------------------------------------------------------------------
  FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
  --------------------------------------------------------------------------------
   719 | ERROR | Expected 1 space before opening brace of class definition; 0
       |       | found
   720 | ERROR | Expected 1 space after colon in style definition; 0 found
  --------------------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/js/slider.js
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   36 | ERROR | Whitespace found at end of line
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• bluez.info: description should be on one line.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Dave Reid as he might have time to take a final look at this.

Hi Ujval,
I downloaded your theme and tested it manually on my localhost XAMPP server. Huge amount of good work you had done. Nice work ! keep it up.

I like theme much more if you think below changes appropriate.

I just tested your theme with 2 column option and single column option(What if web developer want only 2 columns or single column). I found that image stretch for 100% which not looking good. Please see attached screenshot. It will be better if you remove css cod of line number 685 of style.css width: 100%; for .column img

Except above minor things theme is excellent! cheers!!!

itapplication
(Shiv)

Since comment #6 was not an application blocker and this was RTBC for more than a week otherwise ...

Thanks for your contribution, Ujval Shah!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Hi Ujval,

PAReview script did not managed to find any issue of code style. That's good.

So I installed your theme manually and tried to form my user experience.
Advantages:

• Theme is simple, so looking lightweight and good.

Disadvantages:

• There is no link/menu is shown for user. I can log in only on the page /user when I go to it directly. When I'am logged in, still no "Account" link or somewhat else is shown. Maybe this is not important and sure can be added manually afterwards, but this can confuse inexperienced site builders.

Manual review of template.php file:
Lines 34-43:

if (drupal_is_front_page()) {
  drupal_add_js(drupal_get_path('theme', 'bluez') . '/js/slider.js');
}

/**
 * Add Google Fonts.
 */
function bluez_preprocess_html(&$variables) {
  drupal_add_css('http://fonts.googleapis.com/css?family=Open+Sans', array('type' => 'external'));
}

Why do you add JS-file here out of all functions and not in the function in which you add CSS-file (in bluez_preprocess_html(), line 42)? I.e. this can be done like this:

function bluez_preprocess_html(&$variables) {
  drupal_add_css('http://fonts.googleapis.com/css?family=Open+Sans', array('type' => 'external'));
  if (drupal_is_front_page()) {
    drupal_add_js(drupal_get_path('theme', 'bluez') . '/js/slider.js');
  }
}

Regards

Oh, I'm sorry I was making review for 30 minutes and didn't noticed that klausi already set 'fixed' status for this application.
What status should be set now? :-)

Just back to fixed :-)

Hello Ujval,

I have installed Bluez theme for 2 days (direct on server) and now i have a big problem.
I tried to modify the 3 slides images from the banner (with the same size and name) and the website has crashed and i see only this ":)"
I'm disappointed... do you have any solution ?

Please reply me soon as possible!

Hey there! Wonderful theme, and very simple easy setup!

When I created a nested menu system to use the drop down menus, I click on the parent link which has the nested links and the above link disappears?

I took a screenshot to illustrate.

@crispinds,
You need to create issue or report bug on project page, not here.
URL of project page is https://drupal.org/project/bluez

@Ujval Shah,
Be aware if user post issue at wrong place and inform theme about your project issue queue.

@ujval shah : I am also having the same issue with drop down menus as "crispinds" described. Please help .

Hi Ujval,

Great theme. I am using this at my website, but I have a problem. I added two advices you gave about link and drop down menu to my style css, it was great. However, everytime I log on as admin, I still see the main menu in my admin page. Can you help please? Thanks.

Solved, my administrative page was on top of my content. i have disabled it via my settings. great theme Ujval.

Hi,
i tested Bluez , but i have a problem, the menu appeared like that:

and i want to appear it like that: