I needed a div, so i just added it to the module code:

 427         '#options' => array('h2' => t('Header 2'), 'h3' => t('Header 3'), 'div' => t('Div')),

But why not even have a text field for that wrapper, so it can be set to anything?

Files: 
CommentFileSizeAuthor
#17 field_group_allow-tags-in-div-field-groups_2011706-17.patch854 byteskarenann
PASSED: [[SimpleTest]]: [MySQL] 105 pass(es). View
#15 field_group_allow-tags-in-div-field-groups_2011706-15.patch854 byteskarenann
PASSED: [[SimpleTest]]: [MySQL] 105 pass(es). View
#9 field_group-div_instance_settings_text-20117060-9.patch870 byteskarenann
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in field_group-div_instance_settings_text-20117060-9.patch. View
#3 2011706-allow-other-tags-for-fieldgroup-divs.patch805 bytesjpstrikesback
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [2011706-allow-other-tags-for-fieldgroup-divs.patch] from [drupal.org]. View
#1 field_group-missing_label_element-2011706.patch915 bytessirtet
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch field_group-missing_label_element-2011706.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

sirtet’s picture

FileSize
915 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch field_group-missing_label_element-2011706.patch. Unable to apply patch. See the log in the details link for more information. View

here's the patch that adds a Div to the list:

sirtet’s picture

also, the label element can not be changed by code currently, no theme- or preprocess alters are possible.

jpstrikesback’s picture

FileSize
805 bytes
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [2011706-allow-other-tags-for-fieldgroup-divs.patch] from [drupal.org]. View

Thanks sirtet!!

Here it is as a textfield, next up would be to be able to add a label class but we don't have that now anyways...

jpstrikesback’s picture

double post

jpstrikesback’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2011706-allow-other-tags-for-fieldgroup-divs.patch, failed testing.

jpstrikesback’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2011706-allow-other-tags-for-fieldgroup-divs.patch, failed testing.

Anonymous’s picture

Issue summary: View changes

typo

karenann’s picture

Issue summary: View changes
FileSize
870 bytes
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in field_group-div_instance_settings_text-20117060-9.patch. View
jpstrikesback’s picture

Status: Needs work » Needs review

Fire up the bot

jpstrikesback’s picture

Version: 7.x-1.1 » 7.x-1.x-dev

Status: Needs review » Needs work

The last submitted patch, 9: field_group-div_instance_settings_text-20117060-9.patch, failed testing.

jpstrikesback’s picture

The last submitted patch, 3: 2011706-allow-other-tags-for-fieldgroup-divs.patch, failed testing.

karenann’s picture

Status: Needs work » Needs review
FileSize
854 bytes
PASSED: [[SimpleTest]]: [MySQL] 105 pass(es). View

Giving this another shot.

surgeonbor’s picture

#15 works for me, but in the #description, &rt; needs to be changed to & gt ;

karenann’s picture

FileSize
854 bytes
PASSED: [[SimpleTest]]: [MySQL] 105 pass(es). View
Christopher Riley’s picture

It would be great if this was committed so we had more options without a custom module or patch.