Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#15 rename_views_method-2003536-15.patch2.62 KBmarlatt
#15 interdiff.txt2.09 KBmarlatt
#12 drupal_rename_op_regex-2003536-12.patch2.61 KBnathangervais
#10 drupal_rename_op_regex-2003536-10.patch2.61 KBnathangervais
#7 interdiff.txt2.24 KBmarlatt
#7 accessmodifier-2003536-7.patch2.62 KBmarlatt
#5 Rename_Views_method-2003536-5.patch2.6 KBnonprofit

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
sassafrass’s picture

sassafrass commented
Assigned: toddtomlinson » sassafrass
sassafrass’s picture

sassafrass commented
Assigned: sassafrass » Unassigned
nonprofit’s picture

nonprofit commented
Assigned: Unassigned » nonprofit
nonprofit’s picture

nonprofit commented
Assigned: nonprofit » Unassigned
Status: Active » Needs review
StatusFileSize
new Rename_Views_method-2003536-5.patch2.6 KB

Patch created.

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003536-5.patch, failed testing.

marlatt’s picture

marlatt commented
Status: Needs work » Needs review
StatusFileSize
new accessmodifier-2003536-7.patch2.62 KB
new interdiff.txt2.24 KB

Updated access modifiers, re-rolled patch.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Done

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opRegex()

nathangervais’s picture

nathangervais commented
Status: Needs work » Needs review
StatusFileSize
new drupal_rename_op_regex-2003536-10.patch2.61 KB

Rerolled patch to rename op_regex to opRegex

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Numeric.phpundefined
@@ -275,7 +275,7 @@ function op_empty($field) {
+  function opRegex($field) {

public?

nathangervais’s picture

nathangervais commented
Status: Needs work » Needs review
StatusFileSize
new drupal_rename_op_regex-2003536-12.patch2.61 KB

Rerolled patch to add missing public access modifier

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Needs work

Talkes with dawehener about this, should be protected. Srry!

marlatt’s picture

marlatt commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.09 KB
new rename_views_method-2003536-15.patch2.62 KB

Changed method access to protected from public.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Thnx!

oenie’s picture

oenie commented
Title: Rename Views method op_regex() to addRegex() » Rename Views method op_regex() to opRegex()

Changing the title to avoid confusion. op_xxx methods will be renamed to opXxxx instead of addXxx

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method op_regex() to opRegex() » Change notice: Rename Views method op_regex() to opRegex()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Noticed these op_XX functions are all missing doxygen, but xjm told me that's getting taken care of as part of #1856544: [META] Views documentation improvements.

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Change notice: Rename Views method op_regex() to opRegex() » Rename Views method op_regex() to opRegex()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

We'll create a single change notice in the meta.

Automatically closed -- issue fixed for 2 weeks with no activity.