Files: 
CommentFileSizeAuthor
#26 2003252-26.patch1.22 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,269 pass(es). View
#26 interdiff.txt841 bytesjibran
#24 2003252-24.patch1.21 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 55,901 pass(es). View
#21 core-rename_show_value_form_TO_showValueForm-2003252-21.patch1.22 KBThomasVI
PASSED: [[SimpleTest]]: [MySQL] 56,987 pass(es). View
#18 core-rename_show_value_form_TO_showValueForm-2003252-18.patch60.48 KBThomasVI
PASSED: [[SimpleTest]]: [MySQL] 55,939 pass(es). View
#8 core-rename_show_value_form_TO_showValueForm-2003252-8.patch1.21 KBThomasVI
PASSED: [[SimpleTest]]: [MySQL] 56,920 pass(es). View
#3 core-rename_show_value_form_TO_showValueForm-2003252-2.patch1.21 KBThomasVI
FAILED: [[SimpleTest]]: [MySQL] 55,868 pass(es), 1 fail(s), and 0 exception(s). View
#2 core-2003252-2.patch1.21 KBThomasVI
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

ThomasVI’s picture

Assigned: Unassigned » ThomasVI
ThomasVI’s picture

FileSize
1.21 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
ThomasVI’s picture

FileSize
1.21 KB
FAILED: [[SimpleTest]]: [MySQL] 55,868 pass(es), 1 fail(s), and 0 exception(s). View

added a more descriptive patch name

ThomasVI’s picture

Assigned: ThomasVI » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, core-rename_show_value_form_TO_showValueForm-2003252-2.patch, failed testing.

ThomasVI’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, core-rename_show_value_form_TO_showValueForm-2003252-2.patch, failed testing.

ThomasVI’s picture

Status: Needs work » Needs review
FileSize
1.21 KB
PASSED: [[SimpleTest]]: [MySQL] 56,920 pass(es). View

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, core-rename_show_value_form_TO_showValueForm-2003252-8.patch, failed testing.

ThomasVI’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, core-rename_show_value_form_TO_showValueForm-2003252-8.patch, failed testing.

ThomasVI’s picture

I have read through the error, and I can not see why this change camelCase change would have any impact on the BlockRenderOrderTest.php test. Could anyone advise?

SpartyDan’s picture

Status: Needs work » Needs review

I couldn't find the issue but this is a known problem that was fixed. I am re-queuing your patch for testing.

SpartyDan’s picture

ThomasVI’s picture

Thank you Dan.

aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -311,7 +311,7 @@ function operator_submit($form, &$form_state) { }
+  function showValueForm(&$form, &$form_state) {

Should be "protected function showValueForm"

ThomasVI’s picture

Assigned: Unassigned » ThomasVI
ThomasVI’s picture

FileSize
60.48 KB
PASSED: [[SimpleTest]]: [MySQL] 55,939 pass(es). View

Recreated patch to add the protected function showValueForm as per aspilicious in comment #16. ty

ThomasVI’s picture

Assigned: ThomasVI » Unassigned
Status: Needs work » Needs review
ThomasVI’s picture

Assigned: Unassigned » ThomasVI
Status: Needs review » Needs work
ThomasVI’s picture

Assigned: ThomasVI » Unassigned
Status: Needs work » Needs review
FileSize
1.22 KB
PASSED: [[SimpleTest]]: [MySQL] 56,987 pass(es). View

Last patch was bad, re-rolled

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Looks great.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl https://drupal.org/files/core-rename_show_value_form_TO_showValueForm-2003252-21.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1250  100  1250    0     0   1667      0 --:--:-- --:--:-- --:--:--  2166
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php:219
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
1.21 KB
PASSED: [[SimpleTest]]: [MySQL] 55,901 pass(es). View

Re-roll
Conflicts

++<<<<<<< HEAD
 +      // Add the subform from valueForm().
 +      $this->show_value_form($form, $form_state);
++=======
+       // Add the subform from value_form().
+       $this->showValueForm($form, $form_state);
++>>>>>>> 21
++<<<<<<< HEAD
 +  function show_value_form(&$form, &$form_state) {
 +    $this->valueForm($form, $form_state);
++=======
+   protected function showValueForm(&$form, &$form_state) {
+     $this->value_form($form, $form_state);
++>>>>>>> 21

Resolved

 -      // Add the subform from value_form().
 +      // Add the subform from valueForm().
-       $this->show_value_form($form, $form_state);
+       $this->showValueForm($form, $form_state);
-   function show_value_form(&$form, &$form_state) {
 -  protected function showValueForm(&$form, &$form_state) {
 -    $this->value_form($form, $form_state);
++  function showValueForm(&$form, &$form_state) {
 +    $this->valueForm($form, $form_state);
      if (empty($this->no_operator)) {
aspilicious’s picture

Status: Needs review » Needs work

Should be "protected function ... "

jibran’s picture

Status: Needs work » Needs review
FileSize
841 bytes
1.22 KB
PASSED: [[SimpleTest]]: [MySQL] 56,269 pass(es). View

updated the function to protected.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Cool.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b1fcd53 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.