Rename Views method show_value_form() to showValueForm()

added a more descriptive patch name

#3: core-rename_show_value_form_TO_showValueForm-2003252-2.patch queued for re-testing.

#8: core-rename_show_value_form_TO_showValueForm-2003252-8.patch queued for re-testing.

I have read through the error, and I can not see why this change camelCase change would have any impact on the BlockRenderOrderTest.php test. Could anyone advise?

Thank you Dan.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -311,7 +311,7 @@ function operator_submit($form, &$form_state) { }
+  function showValueForm(&$form, &$form_state) {

Should be "protected function showValueForm"

Recreated patch to add the protected function showValueForm as per aspilicious in comment #16. ty

Last patch was bad, re-rolled

Looks great.

Needs a re-roll

curl https://drupal.org/files/core-rename_show_value_form_TO_showValueForm-2003252-21.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1250  100  1250    0     0   1667      0 --:--:-- --:--:-- --:--:--  2166
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php:219
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php: patch does not apply

Re-roll
Conflicts

++<<<<<<< HEAD
 +      // Add the subform from valueForm().
 +      $this->show_value_form($form, $form_state);
++=======
+       // Add the subform from value_form().
+       $this->showValueForm($form, $form_state);
++>>>>>>> 21

++<<<<<<< HEAD
 +  function show_value_form(&$form, &$form_state) {
 +    $this->valueForm($form, $form_state);
++=======
+   protected function showValueForm(&$form, &$form_state) {
+     $this->value_form($form, $form_state);
++>>>>>>> 21

Resolved

 -      // Add the subform from value_form().
 +      // Add the subform from valueForm().
-       $this->show_value_form($form, $form_state);
+       $this->showValueForm($form, $form_state);

-   function show_value_form(&$form, &$form_state) {
 -  protected function showValueForm(&$form, &$form_state) {
 -    $this->value_form($form, $form_state);
++  function showValueForm(&$form, &$form_state) {
 +    $this->valueForm($form, $form_state);
      if (empty($this->no_operator)) {

Should be "protected function ... "

updated the function to protected.

Cool.

Committed b1fcd53 and pushed to 8.x. Thanks!