Files: 
CommentFileSizeAuthor
#10 views-core-2002986-10.patch9.01 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,358 pass(es).
[ View ]
#8 vdc-2002986-8.patch10.47 KBtvlooy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-2002986-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#6 vdc-2002986-6.patch10.39 KBrjleigh
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#2 vdc-2002986.patch7.6 KBjastraat
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es).
[ View ]

Comments

jastraat’s picture

Assigned:Unassigned» jastraat
jastraat’s picture

Status:Active» Needs review
StatusFileSize
new7.6 KB
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es).
[ View ]
adellefrank’s picture

Assigned:jastraat» adellefrank

I am reviewing this with rjleigh.

jastraat’s picture

I already ran simpletest on it.

adellefrank’s picture

That's great! I'm doing a manual review, and I think I found a few files where this still needs changed.

rjleigh’s picture

StatusFileSize
new10.39 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Here's a patch with the other occurrences.

Status:Needs review» Needs work

The last submitted patch, vdc-2002986-6.patch, failed testing.

tvlooy’s picture

Status:Needs work» Needs review
StatusFileSize
new10.47 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vdc-2002986-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Add access modifiers + re-test.

Status:Needs review» Needs work

The last submitted patch, vdc-2002986-8.patch, failed testing.

SpartyDan’s picture

Assigned:adellefrank» Unassigned
Status:Needs work» Needs review
StatusFileSize
new9.01 KB
PASSED: [[SimpleTest]]: [MySQL] 57,358 pass(es).
[ View ]

Previous patch needed to be rerolled and renamed "summary_name_field()" to "summaryName_field()" which was out of scope for this issue.

New patch changes "summary_name(" to "summaryName(" and changes "function summary_name(" to "public function summaryName(".

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views-core-2002986-10.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#10: views-core-2002986-10.patch queued for re-testing.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Good

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 3ad40a3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.