Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#10 views-core-2002986-10.patch9.01 KBSpartyDan
#8 vdc-2002986-8.patch10.47 KBtvlooy
#6 vdc-2002986-6.patch10.39 KBrjleigh
#2 vdc-2002986.patch7.6 KBjastraat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jastraat’s picture

jastraat CreditAttribution: jastraat commented
Assigned: Unassigned » jastraat
jastraat’s picture

jastraat CreditAttribution: jastraat commented
Status: Active » Needs review
FileSize
vdc-2002986.patch7.6 KB
adellefrank’s picture

adellefrank CreditAttribution: adellefrank commented
Assigned: jastraat » adellefrank

I am reviewing this with rjleigh.

jastraat’s picture

jastraat CreditAttribution: jastraat commented

I already ran simpletest on it.

adellefrank’s picture

adellefrank CreditAttribution: adellefrank commented

That's great! I'm doing a manual review, and I think I found a few files where this still needs changed.

rjleigh’s picture

rjleigh CreditAttribution: rjleigh commented
FileSize
vdc-2002986-6.patch10.39 KB

Here's a patch with the other occurrences.

Status: Needs review » Needs work

The last submitted patch, vdc-2002986-6.patch, failed testing.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
Status: Needs work » Needs review
FileSize
vdc-2002986-8.patch10.47 KB

Add access modifiers + re-test.

Status: Needs review » Needs work

The last submitted patch, vdc-2002986-8.patch, failed testing.

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
Assigned: adellefrank » Unassigned
Status: Needs work » Needs review
FileSize
views-core-2002986-10.patch9.01 KB

Previous patch needed to be rerolled and renamed "summary_name_field()" to "summaryName_field()" which was out of scope for this issue.

New patch changes "summary_name(" to "summaryName(" and changes "function summary_name(" to "public function summaryName(".

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-core-2002986-10.patch, failed testing.

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#10: views-core-2002986-10.patch queued for re-testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 3ad40a3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.