Files: 
CommentFileSizeAuthor
#9 rename_getLifespan.2002964.9.patch1.44 KBborisson_
PASSED: [[SimpleTest]]: [MySQL] 57,355 pass(es). View
#2 rename_getLifespan.2002964.2.patch1.43 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site. View

Comments

markie’s picture

Assigned: Unassigned » markie

generating patch

markie’s picture

Status: Active » Needs review
FileSize
1.43 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site. View

patch for your consideration.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, rename_getLifespan.2002964.2.patch, failed testing.

markie’s picture

Status: Needs work » Needs review

#2: rename_getLifespan.2002964.2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, rename_getLifespan.2002964.2.patch, failed testing.

markie’s picture

Status: Needs work » Needs review

#2: rename_getLifespan.2002964.2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, rename_getLifespan.2002964.2.patch, failed testing.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.phpundefined
@@ -97,18 +97,18 @@ public function validateOptionsForm(&$form, &$form_state) {
+  function getLifespan($type) {

Add protected access modifier in front of the function to adhere to the new OOP standards.

borisson_’s picture

Status: Needs work » Needs review
FileSize
1.44 KB
PASSED: [[SimpleTest]]: [MySQL] 57,355 pass(es). View

Added protected function as suggested by oenie.

oenie’s picture

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7b3a7b2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.