Files: 
CommentFileSizeAuthor
#9 2002460-rename-default_not_found.patch1.06 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 54,977 pass(es). View
#4 core-rename-default-not-found-2002460-5.patch1.05 KBAnonymous (not verified)
None View
#2 2002460-rename-default_not_found.patch1.05 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,751 pass(es). View

Comments

sillygwailo’s picture

Assigned: Unassigned » sillygwailo

Taking this with baldwinlouie.

sillygwailo’s picture

Status: Active » Needs review
FileSize
1.05 KB
PASSED: [[SimpleTest]]: [MySQL] 55,751 pass(es). View

Patch attached. Tested with a view that has a path, looks for a contextual filter, and has the contextual filter setting of "Page not found" when there's no argument. Test view is (correctly) page not found where there's no argument, tries to show a view if there is an argument.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -691,7 +691,7 @@ function default_ignore() {
+  function defaultNotFound() {

Add public access modifier in front of the function to adher to the new OOP standards.

Anonymous’s picture

Assigned: sillygwailo » Unassigned
Status: Needs work » Needs review
FileSize
1.05 KB
None View

Re-rolled and added public in front of function name.

dawehner’s picture

Shouldn't that be better protected?

oenie’s picture

@dawehner: i wasn't sure in which context a method like that would be called, which is why i suggested public before.

dawehner’s picture

It's called in ArgumentPluginBase::default_action()

heddn’s picture

Status: Needs review » Needs work
sillygwailo’s picture

Status: Needs work » Needs review
FileSize
1.06 KB
PASSED: [[SimpleTest]]: [MySQL] 54,977 pass(es). View

Re-rolled with protected.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002460-rename-default_not_found.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed e44d062 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.