Files: 
CommentFileSizeAuthor
#6 drupal-views_method_rename-2002382-6.patch1.48 KBdanylevskyi
PASSED: [[SimpleTest]]: [MySQL] 55,865 pass(es). View
#6 interdiff.txt800 bytesdanylevskyi
#2 views.module-renamed-build_group_submit-2002382-02.patch1.05 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

toddtomlinson’s picture

Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

FileSize
1.05 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch attached that renames build_group_submit() to buildGroupSubmit.

toddtomlinson’s picture

Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -665,7 +665,7 @@ function build_group_validate($form, &$form_state) {
+  function buildGroupSubmit($form, &$form_state) {

Add protected access modifier in front of the function to adher to the new OOP standards.

danylevskyi’s picture

Assigned: Unassigned » danylevskyi
danylevskyi’s picture

Status: Needs work » Needs review
FileSize
800 bytes
1.48 KB
PASSED: [[SimpleTest]]: [MySQL] 55,865 pass(es). View
danylevskyi’s picture

Assigned: danylevskyi » Unassigned
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
somepal’s picture

reviewed,gtg

webchick’s picture

Title: Rename Views method build_group_submit() to buildGroupSubmit() » Change notice: Rename Views method build_group_submit() to buildGroupSubmit()
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

jibran’s picture

Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
xjm’s picture

Title: Change notice: Rename Views method build_group_submit() to buildGroupSubmit() » Rename Views method build_group_submit() to buildGroupSubmit()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.