See the attached screenshot. "Show row weights" does not show the weights, and it does hide the drag handles. "Hide row weights" restores the drag handles.

CommentFileSizeAuthor
Screen Shot 2013-05-18 at 3.35.11 PM.png194.13 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

btopro’s picture

gotcha, maybe we need to disable them entirely but I'm not sure about doing so because of accessibility. patch welcome

btopro’s picture

Issue summary: View changes
Status: Active » Closed (won't fix)

accessibility issue, they need to be there

Anonymous’s picture

Status: Closed (won't fix) » Active

I don't understand. The bug is that "Show row weights" does not, in fact, show the row weights.

btopro’s picture

I'll accept a patch to clean up this usability error but this module doesn't really degrade well since it is doing ajax based submissions of something that you can do in a more accessible manner for row weights when outline designer is disabled. How would you suggest handling the item?

Anonymous’s picture

I would suggest removing the functionality if there's no plan to make it work. Having a button that doesn't do what it says, or in fact much of anything at all, is confusing for users.

btopro’s picture

hmm.. looking into it I'm not sure how best to handle it. Basically you could cause the form to be inoperable under certain conditions.

Example: Go to the menu or block pages, click the button that has this same description to "show row weights". Now come back to the outline designer and the functionality of it is effectively removed. This isn't to say there aren't ways around this / improving it / accounting for it; just that it'll require some deeper investigation then just hiding it via CSS / removing from the interface.

  • btopro committed f3580f7 on 7.x-2.x
    minor outline designer UX improvement #1998112
    
btopro’s picture

Version: 7.x-2.0-rc2 » 7.x-2.x-dev
Component: Code / API / JS » Interface
Status: Active » Fixed

nabbed it. should be fixed in dev now without conflicting elsewhere.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.