Closed (fixed)
Project:
Display Suite
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 May 2013 at 10:44 UTC
Updated:
24 Jun 2013 at 08:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
yannickooComment #2
yannickooThe patch should work for 8.x-2.x but I created an extra patch for it :)
Comment #3
swentel commentedthis looks freaky because you now have this:
AND OR AND
without any parentheses, I assume we want to group this no ?
Comment #4
yannickooOh sorry, will add this, hold on :D
Comment #5
yannickooComment #6
yannickooComment #7
aspilicious commentedI don't think your fix is correct:
First you set the variable to TRUE or FALSE and afterwards you check if it equals NULL....
I have the same problem but it is only related to the default view mode afaict.
When accessing the default view_mode the machine name is not appended to the manage display path.
Comment #8
yannickooI will create a follow-up issue for the typo but I figured out that the check for the
$layoutisn't necessary.Comment #9
yannickooComment #10
aspilicious commentedHmmm this could work. I let this to Swentel to verify if it's ok.
If we don't need the $layout checkout we should remove
Comment #11
yannickooThat is true!
Comment #12
yannickooComment #13
swentel commentedSo yeah, that problably makes sense indeed, will test this some more, going to write for a test for it as well to make sure this stays ok in the future.
Comment #14
swentel commentedIronically enough I hit this bug during my demo in Portland, but could not reproduce anymore locally. Anyway committed because the fix looks sane, I've changed the typo's as well in both branches.
Comment #15.0
(not verified) commentedLinked issue