The new twitter version 6 depends on oauth_common but not on oauth, drush doesn't know about the connection so I recommend adding a dependency on oauth module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Category: Task » Bug report
Issue summary: View changes
Status: Active » Needs review
FileSize
752 bytes

Not sure what can be done about this because the OAuth project was poorly named. Maybe this might help?

DamienMcKenna’s picture

Status: Needs review » Needs work

Triggering the testbot.

DamienMcKenna’s picture

Status: Needs work » Needs review

Triggering the testbot.

DamienMcKenna’s picture

steinmb’s picture

Status: Needs review » Active

I suggest we do nothing. This module is not the only one seeing this problem.

Had a look into https://github.com/drush-ops/drush/blob/master/commands/pm/pm.drush.inc

'resolve-dependencies' => 'Attempt to download any missing dependencies. At the moment, only works when the module name is the same as the project name.',

DamienMcKenna’s picture

It's more of a core Drupal limitation than a problem with Drush: #2205271: Project namespace for dependencies

steinmb’s picture

Status: Active » Postponed

Ah thanks :) Should we put this issue to 'postponed' until there is working D7 backported?

DamienMcKenna’s picture

Status: Postponed » Needs review

I'm not sure the issue will be resolved for D7, I think we could do a workaround until then. Would you mind giving the patch a try? Thanks.

steinmb’s picture

Status: Needs review » Needs work

No big difference running from drush.

git branch
* 7.x-6.x

drush en twitter -v
Initialized Drupal 7.34 root directory at /Users/steinmb/sites/twitter/drupal
Initialized Drupal site default at sites/default
Executing: mysql --defaults-extra-file=/private/tmp/drush_utm2YI --database=twitter7 --host=localhost --silent  < /private/tmp/drush_BmBk38
Loading release_info engine.
Downloading release history from https://updates.drupal.org/release-history/oauth_common/7.x
/Users/steinmb/.drush/cache/download/https---updates.drupal.org-release-history-oauth_common-7.x retrieved from cache.
No release history available for oauth_common 7.x.
Module twitter cannot be enabled because it depends on the following modules which could not be found: oauth_common
Command dispatch complete

git apply -v twitter-n1967798-1.patch
Checking patch twitter.install...
Applied patch twitter.install cleanly.

drush en twitter -v
Initialized Drupal 7.34 root directory at /Users/steinmb/sites/twitter/drupal
Initialized Drupal site default at sites/default
Executing: mysql --defaults-extra-file=/private/tmp/drush_tEWeol --database=twitter7 --host=localhost --silent  < /private/tmp/drush_hqyLaC
Loading release_info engine.
Downloading release history from https://updates.drupal.org/release-history/oauth_common/7.x
/Users/steinmb/.drush/cache/download/https---updates.drupal.org-release-history-oauth_common-7.x retrieved from cache.
No release history available for oauth_common 7.x.
Module twitter cannot be enabled because it depends on the following modules which could not be found: oauth_common
Command dispatch complete
DamienMcKenna’s picture

Title: Twitter 6.0 dependencies » Problem with the OAuth / oauth_common dependency
Status: Needs work » Needs review
FileSize
1.49 KB

I finally tested this, and yes, it doesn't work. The reason for this is that hook_requirements() is ran after the info file's dependencies are tested, so we could either remove the line from the info file and use the patch or just deal with it :-\

This patch updates the instructions in README.txt to note the module name conflict.

Status: Needs review » Needs work

The last submitted patch, 10: twitter-n1967798-10.patch, failed testing.

steinmb’s picture

+++ b/README.txt
@@ -7,14 +7,25 @@ provides useful input filters to easily link Twitter accounts and searches withi
+The Twitter module had only been tested to work with the v7.x-3.x releases.

What does this sentence actually mean?

Why do you not think the core issue will be fixed for D7? It is tagged with a "needs backport" and found nothing in the comments it that indicate that I will not be back ported.

Status: Needs work » Needs review

  • DamienMcKenna committed 9adf9f1 on 6.x-5.x
    Issue #1967798 by DamienMcKenna: Updated README.txt to explain about the...

  • DamienMcKenna committed c567849 on
    Issue #1967798 by DamienMcKenna: Updated README.txt to explain about the...
DamienMcKenna’s picture

Committed. I removed the line from the 7.x branches and rewrote it for the 6.x branch so it actually made sense.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.