Feature 7.x-2.0-beta2 defines fields in a new way

Shouldn't this be backwards compatible?

This should be backwards compatible.

ah cool, thx for the patch!

I'll try to make a big patching session at the end of this week. This one is an important one

Patch from #1 doesn't seem to be exporting $field_group->data, though it is adding labels now.

@killtheliterate: Please review the patch in #3, it supersedes #1.

Worked for me in a previously-broken feature.

Tried git apply, then patch <

Didn't apply cleanly, but created this file. I'll take a look at this, though can't right now.

This is a reroll of #3 for 7.x-1.x.

FYI the same patch applies to both 7.x-1.x and 7.x-2.x.

Still not getting anything in field group features exports. Notably, when I run update.php, I encounter the following error:
Notice: Uninitialized string offset: 0 in field_group_unpack() (line 1507 of .../field_group.module)

This patch is not working for me either. For one thing, it didn't apply. But when I got it to apply, it also didn't fix the Fieldgroup/Features problems I am seeing, which I think are supposed to be fixed by this patch?

The behavior I seeing is exactly the same whether I use Fieldgroup 7.x-1.1, or 7.x-1.x-dev with the patch in #10 (and we're using Features 7.x-2.0-rc1):

- I create a feature that includes a Commerce Product type with some fields and field groups on it.
- I verify that the field groups, fields, and field instances are all present on the Create Features page. (With 1.1 or with the patch, the field groups were added automatically to the Feature when I selected the Product type.)
- After downloading and then enabling the Feature, it shows up on the Features page as Overridden, even though I have just created it.
- Checking the overrides with the Diff module shows that the 'data' element of the field group array is empty in the original, and non-empty in the override (i.e. the override appears to be correct, as it shows the fields the group should have inside it). See attached screen shot.
- If I go to the "re-create" tab, there is no change to the feature when I recreate it. It exports exactly the same every time, with an empty 'data' array.

So I think this should probably be set back to "needs work" but because I am not absolutely sure this patch is supposed to address the issue I outlined here, I have not done so. As far as I can tell, the patch doesn't change the behavior of field groups in Features in any way.

I did some debugging about this problem and added a comment to this issue:
#1619154-59: Fieldgroup exported feature reports as Overridden just after creating the feature

I am not sure what I am seeing and reported here in the previous comment is related to this issue, because I am not seeing that this patch does anything good or bad to the Field Group module's features integration... I'll continue the discussion on that other issue I guess.

On the latest -dev version of field_group, I had to manually apply the #10 patch, and when I did, the field groups exported ok, without showing the feature overridden. We're using features 7.x-2.0-rc1.

Re-rolled patch attached to help.

Doesn't seem like this is still RTBC?

When applying the patch, the fieldgroups where still not auto-detected. A small fix was enough, can someone test?
It also looks like the auto-detect of features is broken, you have to push the refresh button first, before he finds any dependencies.

#18: field_group-features-1966624-18.patch queued for re-testing.

#18 has been committed to dev