Tables selected in the "Exclude the data from the following tables" option are exported even when selected in the "Exclude the following tables altogether" option when using mysqldump. They're not exported at all when not using mysqldump command, which I suppose is the right behavior.

I attached a patch that might correct it, needs review.

Thanks!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ronan’s picture

Status: Needs review » Fixed

This is fixed in the latest dev. Should apply the defaults to all databases

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Les Lim’s picture

Version: 7.x-2.4 » 7.x-2.x-dev
Status: Closed (fixed) » Needs review
FileSize
1.07 KB

This is still broken with mysqldump if there aren't any "exclude" tables. Patch attached.

Les Lim’s picture

FileSize
949 bytes

Sorry, here's the patch with "git diff --relative".

This also applies to 7.x-3.x.

ronan’s picture

Status: Needs review » Fixed

Applied to both branches. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tinkerbelle’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
2.26 KB

I am still having these problems using CLI/mysqldump in both 7.x-3.1 & the latest dev, on multiple sites. Specifically:

1. The 'exclude data' settings are ignored if nothing is selected in the 'exclude altogether' dropdown,

2. Tables selected in 'exclude altogether' still have their structure exported if they're also selected in the 'exclude data' dropdown.

I've attached the patch I'm using to solve both issues -- it applies a version of the initial patch above, and the patch in #4, to sources.db.mysql.inc

I admit I'm confused about whether any of this actually needs doing in destinations.db.mysql.inc too, so I'll leave this in your hands :) Cheers!

couturier’s picture

Status: Needs review » Closed (cannot reproduce)