Tables selected in the "Exclude the data from the following tables" option are exported even when selected in the "Exclude the following tables altogether" option when using mysqldump. They're not exported at all when not using mysqldump command, which I suppose is the right behavior.
I attached a patch that might correct it, needs review.
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | backup_migrate-cli-fixes-1947206-7.patch | 2.26 KB | tinkerbelle |
| #4 | backup_migrate-1947206-4.patch | 949 bytes | les lim |
| #3 | backup_migrate-1947206-3.patch | 1.07 KB | les lim |
| destinations.db_.mysql_.inc_.patch | 335 bytes | erickbj |
Comments
Comment #1
ronan commentedThis is fixed in the latest dev. Should apply the defaults to all databases
Comment #3
les limThis is still broken with mysqldump if there aren't any "exclude" tables. Patch attached.
Comment #4
les limSorry, here's the patch with "git diff --relative".
This also applies to 7.x-3.x.
Comment #5
ronan commentedApplied to both branches. Thanks!
Comment #7
tinkerbelle commentedI am still having these problems using CLI/mysqldump in both 7.x-3.1 & the latest dev, on multiple sites. Specifically:
1. The 'exclude data' settings are ignored if nothing is selected in the 'exclude altogether' dropdown,
2. Tables selected in 'exclude altogether' still have their structure exported if they're also selected in the 'exclude data' dropdown.
I've attached the patch I'm using to solve both issues -- it applies a version of the initial patch above, and the patch in #4, to sources.db.mysql.inc
I admit I'm confused about whether any of this actually needs doing in destinations.db.mysql.inc too, so I'll leave this in your hands :) Cheers!
Comment #8
couturier commented