Patch (to be ported)
Project:
Workbench Moderation
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2013 at 15:25 UTC
Updated:
20 May 2016 at 16:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Darshi Shah commentedI am also having the same notice but with different line number. I am using dev version.
Notice: Undefined index: workbench_moderation_state_new in workbench_moderation_form_node_form_alter() (line 866 of workbench_moderation/workbench_moderation.module).
I am using msnf module and this error appears on last step of adding content where moderation notes are there.
Thanks
Comment #2
pkil commentedtry the following:
http://drupal.org/node/1606704
Comment #3
pfrenssenThe issue mentioned in #2 is about a problem in Workbench Moderation Notes and is unrelated to this issue.
I can confirm this notice occurring when logged in as a user that has no workbench moderation permissions. When I add the "bypass workbench moderation" permission to the user role the notice disappears.
Comment #4
jmoughon commentedHere is patch that does a simple check to see if the $form['revision_information']['workbench_moderation_state_new'] is set.
Comment #5
jmoughon commentedLeft out a ) sorry.
Comment #6
alberto56 commentedSet the previous patch to needs review so it gets tested.
Comment #8
jmoughon commentedLets see if this works
Comment #9
jmoughon commentedNeeds review
Comment #11
jmoughon commentedTrying again
Comment #12
pfrenssenIt's not needed to enclose the ternary operator in parentheses. The assignment operator
=has lower precedence than the ternary operator. See Operator precedence.Comment #13
aspilicious commentedCan we get a quick reroll? Needed to patch this.
Happens with users that only can edit draft versions without extra permissions.
Comment #14
yareckon commentedComment #16
rbrandon commented@yareckon that is correct. @jmoughon your patch looks good, applying the small change yareckon mentions so this can be closed/committed.
Comment #17
heddnIf the testbot likes this, then RTBC. I'm using the patch on a site that is going live in the next few weeks and it resolves the issue.
Comment #18
heddnComment #19
ladybug_3777 commentedCan we get this committed yet? The patch at #16 works great for me.
Comment #20
damienmckennaDoes it still apply against v7.x-1.x-dev?
Comment #22
lukusPlease commit this .. #16 working well for me also.
Thanks.
Comment #23
AlexKirienko commented#16 working on 7.x-1.3+10-dev
Comment #24
rv0 commented+1 for #16
Comment #26
colanThanks!