This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes). Check meta issue for Steps to reproduce and Coding standards

Files need to be fixed
system.authorize.yml
system.date.yml
system.file.yml
system.mail.yml
system.maintenance.yml
system.menu.yml

Files fixed already
system.cron.yml
system.filter.yml
system.logging.yml
system.module.yml
system.performance.yml
system.rss.yml
system.site.yml
system.theme.yml
system.timezone.yml

Files: 
CommentFileSizeAuthor
#2 1942168-system-config-fix-1.patch2.02 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1942168-system-config-fix-1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

vijaycs85’s picture

Title: Make OpenID module active config save format match the default yml file. » Make System module active config save format match the default yml file.
vijaycs85’s picture

Status: Active » Needs review
FileSize
2.02 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1942168-system-config-fix-1.patch. Unable to apply patch. See the log in the details link for more information. View

system.date.yml - using single quotes for escaping and double codes for string - Replace singlequotes with "\".
system.file.yml - active storage has no comment in it.

sidharthap’s picture

Thanks @Vijaycs85, It looks good for system.authorize.yml, system.mail.yml, system.maintenance.yml, system.menu.yml and for other files i found some issues.
1 - Some places it is removing single quotes (system.date.yml)
2 - Escapeing the escape charater (Ex: T) in date format. (system.date.yml)
3 - Comments line removes in active config. (system.file.yml)

sidharthap’s picture

Status: Needs review » Needs work

Changeing status to needs work as per #3.

vijaycs85’s picture

Status: Needs work » Needs review

Thanks @sidharthap. here some updates on individual points

#3.1 - Yes, Yaml does that, but for consistency we use single quotes for data that can get space or ':'.
#3.2 - Created a new issue #1944636: PECL Intl extension usage in DateTimePlus class broken and untested
#3.3 - Guess, we are fine with comments.

Setting it to needs review as we don't have anything to fix in this issue for #3.

vijaycs85’s picture

Status: Needs review » Needs work
Issue tags: +Configuration system, +Config novice

The last submitted patch, 1942168-system-config-fix-1.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Postponed

Part of the fixes went in with other patches(#1947814: New config entities often save as langcode: und incorrectly) and remaining part is in #1944636: PECL Intl extension usage in DateTimePlus class broken and untested. Just keeping it postponed until [#1944636]get committed. Can be closed, if nothing left to fix.

vijaycs85’s picture

Status: Postponed » Needs work
vijaycs85’s picture

Status: Needs work » Fixed

As per #8 marking this fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.