Empty toolbar sub-menu looks funny; Don't render empty trays

Could you document how to reproduce this?
I haven't see this issue and am not sure what steps are needed to make the problem manifest itself.

I found two ways to reproduce the issue:

1. Disable certain menu links of menu 'Administration menu'.
2. Login as a user that has access to the toolbar, but not to the links.

1. Disable certain menu links of menu 'Administration menu':

1. Go to admin/structure/menu.
2. Edit the menu 'Administration menu'.
3. Disable the following links:
   • Content
   • Structure
   • Appearance
   • People
   • Configuration
   • Reports
   • Help

2. Login as a user that has access to the toolbar, but not to the links:

1. Create a user with a role that has only the permission "Use the administration toolbar".
2. Login as this user.

The patch fixes the "silly" looking toolbar submenu (tested in Safari only), but I wonder if the submenu should be shown at all when there are no links to display? Now, with the patch applied, you just have an empty toolbar submenu (see also the attached screenshot). That doesn't look useful to me (though it's probably better than the situation posted in #0).

Created a patch for hide toolbar submenu if there are no any links.

I wanted try Your patch, but I can't apply it.
There isn't toolbar.base.css file on drupal folders.

It seems that there is a change in files structure.
And problem with toolbar sub-menu is fixed.

But - when I try reproduce suggestion #4 (variant 2) I found this behavior:

Ordinary user have after login page like this

If I elevate user permission to "Use the administration toolbar "

Then main page changes as follows (white area appear on left side and administration toolbar cover right top corner)

Diferences in pages source code ...

Thank you for logging this. I'm upping the priority to Normal. It may need to go to Major, but not yet.

This should be dealt with at the render layer, not the CSS. CSS is just masking bad behavior in the PHP.

jessehs, do you feel comfortable proposing a fix for the PHP side?

Closing this as duplicate in favor of #2135445: Toolbar displays Manage tab even if the user is not permitted to see it, it has a better summary and a working patch.