Just clicking around today I noticed that the conditions don't work if you don't have any nodes.
I realize this is an edge case, but if people start mimicking core conditions, they'll hit more realistic bugs.

I'll check through other plugins to see if they need similar treatment.

Files: 
CommentFileSizeAuthor
node-condition-PASS.patch1.7 KBtim.plunkett
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch node-condition-PASS.patch. Unable to apply patch. See the log in the details link for more information. View
node-condition-FAIL.patch1007 bytestim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 52,627 pass(es), 0 fail(s), and 1 exception(s). View

Comments

PKJedi queued node-condition-PASS.patch for re-testing.

Status:Needs review» Needs work

The last submitted patch, node-condition-PASS.patch, failed testing.

Version:8.0.x-dev» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.