#1921996: Convert system_config_form() to implement FormInterface as a base class. adds a base class to allow FormInterface to mimic system_config_form(). We should convert all of them to it. This is the meta for that.

These are currently the only modules that use system_config_form().

Module Assigned Issue link
aggregator module #1925048: Convert aggregator's system_config_form() to SystemConfigFormBase
book module #1925196: Convert book's system_config_form() to SystemConfigFormBase
forum module larowlan #1925252: Convert forum's system_config_form() to SystemConfigFormBase
language module tim.plunkett #1925738: Convert language's system_config_form() to SystemConfigFormBase
locale module #1938014: Convert locale's system_config_form() to SystemConfigFormBase
menu module floretan #1938008: Convert menu.module's system_config_form() to SystemConfigFormBase
rest module #1925636: Convert rest's system_config_form() to SystemConfigFormBase
search module ACF #1933518: Convert search's system_config_form() to SystemConfigFormBase
simpletest module #1937944: Convert simpletest's system_config_form() to SystemConfigFormBase
statistics module #1937968: Convert statistics's system_config_form() to SystemConfigFormBase
system module #1925660: Convert system's system_config_form() to SystemConfigFormBase
update module #1937998: Convert update's system_config_form() to SystemConfigFormBase
user module #1924992: Convert user's system_config_form() to SystemConfigFormBase
CommentFileSizeAuthor
#7 system_config_form-1924990-7.patch2.37 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

assigning user to me

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

removed stray *

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +FormInterface

Okay, I did user and aggregator as examples.

All conversions should use routes and be defined as a service ID, so that config.factory can be injected in.
Aggregator has the additional example of how to inject other dependencies.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

added aggregator issue

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

added book

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Added #1925252: Convert forum's system_config_form() to SystemConfigFormBase

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes

Updated issue summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

Updated issue summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes

Updated issue summary.

catch’s picture

catch
he/him
Primary language English
commented

I don't want to convert any more routes as services until #1915774: Decide whether core route controllers should generally/always be DIC services or not is resolved. This is exactly the sort of service bloat I'm concerned about in the other issue.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes

Updated issue summary.

ACF’s picture

ACF commented
Issue summary: View changes

added search

yesct’s picture

yesct commented
Issue tags: +Novice

ok. 1915774 was committed. it's waiting on a change notice, so that's why it's open. We can proceed creating the rest of the conversion issues. Since there are examples already, I'm tagging with novice.

When creating the issues, look at the examples already in the issue summary and be sure and update this issue summary and link the issues together.

yesct’s picture

yesct commented
Issue summary: View changes

Updated

ACF’s picture

ACF commented
Issue summary: View changes

Added simpletest issue.

ACF’s picture

ACF commented
Issue summary: View changes

Added simpletest issue properly

ACF’s picture

ACF commented
Issue summary: View changes

Add statistics issue.

ACF’s picture

ACF commented
Issue summary: View changes

Add update issue

floretan’s picture

floretan commented
Issue summary: View changes

Add link to the menu module issue.

floretan’s picture

floretan commented
Issue summary: View changes

Indicate the menu module issue is assigned to me.

amateescu’s picture

amateescu commented

I've rerolled aggregator, update and user (#1925048-6: Convert aggregator's system_config_form() to SystemConfigFormBase, #1937998-2: Convert update's system_config_form() to SystemConfigFormBase and #1924992-9: Convert user's system_config_form() to SystemConfigFormBase) to account for #1934832: Provide a dedicated approach for using forms in routes which got committed in the meantime.

All the other patches need to follow the new pattern for converting forms, the main difference being that you no longer have to create a service for each form class. More details and examples are in #1934832: Provide a dedicated approach for using forms in routes.

amateescu’s picture

amateescu commented
Issue tags: +SprintWeekend2013

Add sprintweekend tag.

amateescu’s picture

amateescu commented
Issue summary: View changes

Add locale issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new system_config_form-1924990-7.patch2.37 KB

We can now kill off system_config_form()! Yay

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Yay!!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: [meta] Convert all of system_config_form() to SystemConfigFormBase » Change notice: [meta] Convert all of system_config_form() to SystemConfigFormBase
Priority: Major » Critical
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Need to update https://drupal.org/node/1910694

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

http://drupalcode.org/project/drupal.git/commit/1356c25

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Title: Change notice: [meta] Convert all of system_config_form() to SystemConfigFormBase » [meta] Convert all of system_config_form() to SystemConfigFormBase
Priority: Critical » Major
Status: Active » Fixed
Issue tags: -Needs change record

Updated the notice: https://drupal.org/node/1910694/revisions/view/2680038/2742025

Automatically closed -- issue fixed for 2 weeks with no activity.