Subissue of #1924990: [meta] Convert all of system_config_form() to SystemConfigFormBase.

CommentFileSizeAuthor
#9 1938014-forminterface-locale-drupal-9.patch12.53 KBACF
#6 1938014-forminterface-locale-drupal-6.patch12.53 KBACF
#4 1938014-forminterface-locale-drupal-4.patch12.39 KBACF
#2 1938014-forminterface-locale-drupal-2.patch13.96 KBACF
#1 1938014-forminterface-locale-drupal-1.patch13.68 KBACF

Comments

ACF’s picture

ACF commented
Status: Active » Needs review
StatusFileSize
new 1938014-forminterface-locale-drupal-1.patch13.68 KB
ACF’s picture

ACF commented
StatusFileSize
new 1938014-forminterface-locale-drupal-2.patch13.96 KB

Updated to use the form controller.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work 
+++ b/core/modules/language/language.moduleundefined
+++ b/core/modules/language/language.moduleundefined
@@ -1,4 +1,4 @@

@@ -1,4 +1,4 @@
-<?php
+1<?php
 
 /**

:)

+++ b/core/modules/locale/lib/Drupal/locale/Form/LocaleFormBase.phpundefined
@@ -0,0 +1,46 @@
+abstract class LocaleFormBase extends SystemConfigFormBase implements ControllerInterface {

This isn't needed anymore, its all in the SystemConfigBase now

ACF’s picture

ACF commented
Status: Needs work » Needs review
StatusFileSize
new 1938014-forminterface-locale-drupal-4.patch12.39 KB

Thanks for looking hopefully this is better.

Crell’s picture

Crell commented
Status: Needs review » Needs work 
+++ b/core/modules/locale/locale.module
@@ -215,8 +215,7 @@ function locale_menu() {
-    'page callback' => 'drupal_get_form',
-    'page arguments' => array('locale_translate_settings'),
+    'page callback' => 'NOT_USED',
     'access arguments' => array('translate interface'),

Not more "NOT_USED". Instead, have a "route" key that refers to the name of the route from the yaml file.

ACF’s picture

ACF commented
Status: Needs work » Needs review
StatusFileSize
new 1938014-forminterface-locale-drupal-6.patch12.53 KB

Updated with the change.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

The bot can complain if it disagrees.

Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Needs work

Oh crap. Totally my fault. We changed it. It's now "route_name", not "route". :-( Sorry.

ACF’s picture

ACF commented
Status: Needs work » Needs review
StatusFileSize
new 1938014-forminterface-locale-drupal-9.patch12.53 KB

No worries, thanks for the review.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Huzzah!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +SprintWeekend2013

Great work!

Committed and pushed to 8.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.