In the tasks

  • comment_reply
  • node_view
  • user_edit
  • user_view

there isn't a strict check if ctools_context_handler_render returns FALSE so a empty string is not accepted as valid output and the fallback action is called.

Attached patch.

CommentFileSizeAuthor
#3 strict_check_ctools_context_handler_render-1907242-3.patch1.97 KBmrjmd
strict_check_ctools_context_handler_render-1.patch2.06 KBlogaritmisk

Comments

DamienMcKenna queued strict_check_ctools_context_handler_render-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, strict_check_ctools_context_handler_render-1.patch, failed testing.

mrjmd’s picture

mrjmd commented
Issue summary: View changes
StatusFileSize
new strict_check_ctools_context_handler_render-1907242-3.patch1.97 KB

Here's a reroll.

mrjmd’s picture

mrjmd commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

For confirmation, the return statement from ctools_context_handler_render() has the following note:

Either the output or NULL if there was output, FALSE if no handler accepted the task. If $page is FALSE then the $info block is returned instead.

This patch fixes the issue.

mrjmd’s picture

mrjmd commented
Parent issue: » #2401915: META: Plan for CTools 7.x-1.6 release
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +SprintWeekend2015

Looks good. Committed.

  • japerry committed 7f9e55d on 7.x-1.x authored by mrjmd 
    Issue #1907242 by mrjmd, logaritmisk: Strict check if...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.