I think it would be great to create a date format which use "time ago" format for today but another format for other days.

CommentFileSizeAuthor
#32 interdiff-31-32.txt1.05 KBtonytheferg
#32 1905132-32.patch8.53 KBtonytheferg
#31 interdiff-30-31.txt1.16 KBtonytheferg
#31 1905132-31.patch8.54 KBtonytheferg
#30 interdiff-29-30.txt3.27 KBtonytheferg
#30 1905132-30.patch8.54 KBtonytheferg
#29 interdiff-27-29.txt3.37 KBtonytheferg
#29 1905132-29.patch5.27 KBtonytheferg
#27 1905132-27.patch5.38 KBtonytheferg
#8 1905132-8.patch8.43 KBkalman.hosszu
#8 interdiff_1905132-6_1905132-8.txt1.17 KBkalman.hosszu
#6 1905132-6.patch8.58 KBkalman.hosszu
#6 interdiff_1905132-3-1905132-6.txt2.69 KBkalman.hosszu
#3 1905132-3.patch5.89 KBkalman.hosszu
#3 interdiff_1905132-1_1905132-3.txt1.84 KBkalman.hosszu
#1 1905132-1.patch5.88 KBkalman.hosszu

Comments

kalman.hosszu’s picture

kalman.hosszu commented
Status: Active » Needs review
StatusFileSize
new 1905132-1.patch5.88 KB

Hi,

the patch is attached. Please review it

Cheers,
Kalman

Anonymous’s picture

Anonymous (not verified) commented

i have tested your patch, all functionality is OK, i only noticed some minor language usage issues:

+ 'today time ago' => t('Time ago (with "ago" appended) for today date, but not for other dates'),
should be today's date

+ '#description' => t('If "Custom" selected in "Second date format", see the <a href="@url" target="_blank">PHP manual</a> for date formats. Otherwise, enter the number of different time units to display, which defaults to 2.', array('@url' => 'http://php.net/manual/function.date.php')),
should be If "Custom" is selected for "Second date format"

kalman.hosszu’s picture

kalman.hosszu commented
StatusFileSize
new interdiff_1905132-1_1905132-3.txt1.84 KB
new 1905132-3.patch5.89 KB

Thanks dekztah, I fixed the patch based on your remarks.

k.dani’s picture

k.dani commented
Status: Needs review » Reviewed & tested by the community

The patch in comment #3 works as it should for me...thanks for it.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Need tests

Shouldn't we extend the test coverage for that? I know we have simple test coverage for date fields, so please let's extend it here,
just to be able to sleep better.

kalman.hosszu’s picture

kalman.hosszu commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_1905132-3-1905132-6.txt2.69 KB
new 1905132-6.patch8.58 KB

I modified the patch with the test. Please review it!

Status: Needs review » Needs work

The last submitted patch, 1905132-6.patch, failed testing.

kalman.hosszu’s picture

kalman.hosszu commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_1905132-6_1905132-8.txt1.17 KB
new 1905132-8.patch8.43 KB

New data row is moved to ViewsHandlerFieldDateTest class.

kalman.hosszu’s picture

kalman.hosszu commented

#8: 1905132-8.patch queued for re-testing.

k.dani’s picture

k.dani commented
Status: Needs review » Reviewed & tested by the community

I tested it and it worked like a charm.

kalman.hosszu’s picture

kalman.hosszu commented

#8: 1905132-8.patch queued for re-testing.

kalman.hosszu’s picture

kalman.hosszu commented

@dawehner Need I do anything else to commit this feature request?

kalman.hosszu’s picture

kalman.hosszu commented

8: 1905132-8.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Project: Views (for Drupal 7) » Drupal core
Version: 7.x-3.x-dev » 8.x-dev
Component: User interface » views.module
Issue summary: View changes
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: -Need tests

Committed and pushed. Thank you!

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Status: Patch (to be ported) » Needs work

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
tonytheferg’s picture

tonytheferg commented

Would love to see this get ported!

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new 1905132-27.patch5.38 KB

quick patch port for 9.4.x, no tests, but I can get to it.

tonytheferg’s picture

tonytheferg commented
Status: Needs work » Needs review

Would like to get some direction from core maintainers on what they would want to see here.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new 1905132-29.patch5.27 KB
new interdiff-27-29.txt3.37 KB

Cleaner. Still needs tests added.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new 1905132-30.patch8.54 KB
new interdiff-29-30.txt3.27 KB

Here is a patch that adds the tests.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new 1905132-31.patch8.54 KB
new interdiff-30-31.txt1.16 KB

accidently added a couple of extra lines in the test port. Maybe someone can take it from here. :)

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new 1905132-32.patch8.53 KB
new interdiff-31-32.txt1.05 KB

Blah. missed a short array syntax.

Also, I see now that the current tests already have dataset() so not sure how to merge this hunk from 7:

  /**
   * Appends dataSet() with a data row for "today time ago" format testing.
   */
  protected function dataSet() {
    $data = parent::dataSet();
    $data[] = [
      'name' => 'David',
      'age' => 25,
      'job' => 'Singer',
      'created' => REQUEST_TIME - 120,
    ];

    return $data;
  }

Left the duplicate in for now, but I can't imagine this will pass tests. 😂

Status: Needs review » Needs work

The last submitted patch, 32: 1905132-32.patch, failed testing. View results

tonytheferg’s picture

tonytheferg commented

Needs schema, and dataSet() fixed

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

tonytheferg’s picture

tonytheferg commented

needs reroll for 10.2.3

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.