Similar to #538494: Provide user view categories as separate panes, but for the user edit form.

This is needed to allow Profile2 forms to be used.

CommentFileSizeAuthor
#13 ctools-pass_category_to_profile_form-1892850-13.patch679 bytesalex.bukach
#10 ctools-pass_category_to_profile_form-1892850-10.patch688 bytesalex.bukach
#5 ctools-pass_category_to_profile_form-1892850-5.patch1.25 KBalex.bukach
#4 ctools-pass_category_to_profile_form-1892850-3.patch651 bytesalex.bukach
#1 ctools-1892850-1.patch4.88 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new ctools-1892850-1.patch4.88 KB

Okay, with some help from merlinofchaos I was able to get this working.

You can now add a relationship from a user to their profile edit form.
In addition to user/%user/edit, the panel will also be loaded for user/%user_category/edit/%.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
Status: Needs review » Fixed

I tested this in several different scenarios, and ended up committing http://drupalcode.org/project/ctools.git/commit/d58d900

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alex.bukach’s picture

alex.bukach commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
StatusFileSize
new ctools-pass_category_to_profile_form-1892850-3.patch651 bytes

The patch above does not send category to the profile form in fallback case. Here's a patch to fix it.

alex.bukach’s picture

alex.bukach commented
StatusFileSize
new ctools-pass_category_to_profile_form-1892850-5.patch1.25 KB

Moreover, if fallback is not the case, ctools_context_create_user_edit_form() does not use the category. Current patch fixes this as well (not sure whether in the most natural way).

alex.bukach’s picture

alex.bukach commented

Was anybody able to check the patch?

  • tim.plunkett committed b8671ef on 8.x-2.x 
    Issue #1892850 by tim.plunkett: Follow-up: ensure when the context is...
  • tim.plunkett committed d58d900 on 8.x-2.x
    Issue #1892850 by tim.plunkett: Allow specific user category profile...

DamienMcKenna queued 5: ctools-pass_category_to_profile_form-1892850-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: ctools-pass_category_to_profile_form-1892850-5.patch, failed testing.

alex.bukach’s picture

alex.bukach commented
Status: Needs work » Needs review
StatusFileSize
new ctools-pass_category_to_profile_form-1892850-10.patch688 bytes

Here's re-rolled patch for 7.x-1.x-dev. The first part of the patch in #5 (i.e. the whole patch in #4) appear to have been committed.

  • tim.plunkett committed b8671ef on 8.x-3.x 
    Issue #1892850 by tim.plunkett: Follow-up: ensure when the context is...
  • tim.plunkett committed d58d900 on 8.x-3.x
    Issue #1892850 by tim.plunkett: Allow specific user category profile...
alex.bukach’s picture

alex.bukach commented

@tim.plunkett is it possible to commit the patch from #10 to 7.x? Do you have any concerns?

alex.bukach’s picture

alex.bukach commented
StatusFileSize
new ctools-pass_category_to_profile_form-1892850-13.patch679 bytes

Re-rolled against the current dev.

Konstantin Komelin’s picture

Konstantin Komelin commented

Vote for #13. Works for me

chris matthews’s picture

chris matthews commented

The 3 year old patch in #13 to user_edit_form.inc applied cleanly to the latest ctools 7.x-1.x-dev and (if still applicable) probably needs another review.

Checking patch plugins/contexts/user_edit_form.inc...
Applied patch plugins/contexts/user_edit_form.inc cleanly.
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.