Similar to #538494: Provide user view categories as separate panes, but for the user edit form.

This is needed to allow Profile2 forms to be used.

Files: 
CommentFileSizeAuthor
#13 ctools-pass_category_to_profile_form-1892850-13.patch679 bytesAlex Bukach
PASSED: [[SimpleTest]]: [MySQL] 121 pass(es). View
#10 ctools-pass_category_to_profile_form-1892850-10.patch688 bytesAlex Bukach
PASSED: [[SimpleTest]]: [MySQL] 121 pass(es). View
#1 ctools-1892850-1.patch4.88 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 67 pass(es). View

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
4.88 KB
PASSED: [[SimpleTest]]: [MySQL] 67 pass(es). View

Okay, with some help from merlinofchaos I was able to get this working.

You can now add a relationship from a user to their profile edit form.
In addition to user/%user/edit, the panel will also be loaded for user/%user_category/edit/%.

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Status: Needs review » Fixed

I tested this in several different scenarios, and ended up committing http://drupalcode.org/project/ctools.git/commit/d58d900

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Alex Bukach’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
651 bytes
PASSED: [[SimpleTest]]: [MySQL] 121 pass(es). View

The patch above does not send category to the profile form in fallback case. Here's a patch to fix it.

Alex Bukach’s picture

FileSize
1.25 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ctools-pass_category_to_profile_form-1892850-5.patch. Unable to apply patch. See the log in the details link for more information. View

Moreover, if fallback is not the case, ctools_context_create_user_edit_form() does not use the category. Current patch fixes this as well (not sure whether in the most natural way).

Alex Bukach’s picture

Was anybody able to check the patch?

  • tim.plunkett committed b8671ef on 8.x-2.x
    Issue #1892850 by tim.plunkett: Follow-up: ensure when the context is...
  • tim.plunkett committed d58d900 on 8.x-2.x
    Issue #1892850 by tim.plunkett: Allow specific user category profile...

Status: Needs review » Needs work

The last submitted patch, 5: ctools-pass_category_to_profile_form-1892850-5.patch, failed testing.

Alex Bukach’s picture

Status: Needs work » Needs review
FileSize
688 bytes
PASSED: [[SimpleTest]]: [MySQL] 121 pass(es). View

Here's re-rolled patch for 7.x-1.x-dev. The first part of the patch in #5 (i.e. the whole patch in #4) appear to have been committed.

  • tim.plunkett committed b8671ef on 8.x-3.x
    Issue #1892850 by tim.plunkett: Follow-up: ensure when the context is...
  • tim.plunkett committed d58d900 on 8.x-3.x
    Issue #1892850 by tim.plunkett: Allow specific user category profile...
Alex Bukach’s picture

@tim.plunkett is it possible to commit the patch from #10 to 7.x? Do you have any concerns?

Alex Bukach’s picture

FileSize
679 bytes
PASSED: [[SimpleTest]]: [MySQL] 121 pass(es). View

Re-rolled against the current dev.

Konstantin Komelin’s picture

Vote for #13. Works for me