replace reset param in flag_get_user_flags() with drupal_static_reset() [#1886560]

We can simplify this function by removing the $reset param, and using drupal_static_reset() when we want to reset its cache instead.

Comment	File	Size	Author
#3	flag-replace-reset-param-in-flag-get-user-flags-1886560-3.patch	1.68 KB	alexweber
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alexweber CreditAttribution: alexweber commented 19 January 2013 at 22:30

The $reset implementation is simple enough... if we remove the param we won't know when to reset it, where would the drupal_static_reset() go?

Comment #2

joachim CreditAttribution: joachim commented 20 January 2013 at 11:42

There's only one place where the reset functionality is used, and it's called like this:

    flag_get_user_flags(NULL, NULL, NULL, NULL, TRUE);

This is a pattern that was quite common in core up to D6, but for D7 it's been replaced with drupal_static_reset() -- so instead of that awkward call with all the NULL, call drupal_static_reset() with the name of the static cache to clear.

Comment #3

alexweber CreditAttribution: alexweber commented 20 January 2013 at 22:52

Status:

Active

» Needs review

File	Size
flag-replace-reset-param-in-flag-get-user-flags-1886560-3.patch	1.68 KB

Thanks Joachim, that makes sense now :)

FYI: I've created a new related issue: #1894030: replace reset param in flag_get_counts() with drupal_static_reset()

Comment #4

joachim CreditAttribution: joachim commented 21 January 2013 at 09:56

Status:

Needs review

» Fixed

Thanks!

git commit -m "Issue #1886560 by alexweber: Removed reset parameter in flag_get_user_flags() in favour of drupal_static_reset()." --author="alexweber "