Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yannickoo’s picture

Status: Active » Needs review
FileSize
764 bytes
swentel’s picture

Hmm, I guess why not, maybe we should update the description then as well that people can enter zero (or is a select box right now, don't know anymore) to have no limit.

yannickoo’s picture

I also thought about updating the description but what would be the description? Views is using "The number of items to display per page. Enter 0 for no limit.".

Oh, wrote wrong comment number ;)

yannickoo’s picture

swentel’s picture

Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Needs review » Patch (to be ported)

Don't worry about the number :)

Committed and pushed, thanks, moving to 8.x-2.x

yannickoo’s picture

Status: Patch (to be ported) » Needs review
FileSize
1.36 KB

That was not a big deal :)

swentel’s picture

Status: Needs review » Closed (fixed)

Alright, all in, thanks :)

swentel’s picture

We might need to reroll this for the D8 version though, just spotted #702940: Make the number of results per page configurable, we'll see what happens.

yannickoo’s picture

Version: 8.x-2.x-dev » 7.x-2.x-dev
Status: Closed (fixed) » Needs review
FileSize
977 bytes

Hey swentel, sorry for reopening but I had a problem with the "unlimited feature" and we don't remove the limit if we have unlimited values so we should only add the ->extend('PagerDefault'); stuff if a limit was set. Otherwise it doesn't work :/

swentel’s picture

Status: Needs review » Closed (fixed)

Good call, committed and pushed.

swentel’s picture

Status: Closed (fixed) » Active

Something went completely wrong here, reopening

yannickoo’s picture

What do you mean with completely wrong?

swentel’s picture

Errors like this :

Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'SelectQuery' does not have a method 'limit' in SelectQueryExtender->__call() (line 840 of /Users/drupal/drupal7/includes/database/select.inc).

swentel’s picture

FileSize
978 bytes

Reverted for now - and also a new release

yannickoo’s picture

Status: Active » Needs work

Oh that is new to me. But now we have to remove the limit if $limit is 0.

+++ b/modules/ds_search/ds_search.moduleundefined
@@ -401,7 +401,7 @@ function ds_search_search_page($results) {
+  $query = db_select('search_index', 'i', array('target' => 'slave'))->extend('SearchQuery')->extend('PagerDefault');;

Double semicolon ;)

yannickoo’s picture

Status: Needs work » Needs review
FileSize
708 bytes

So here is a proper patch for the fix.

swentel’s picture

Status: Needs review » Active

Committed

aspilicious’s picture

I'm confused, whats the status of this issue?

yannickoo’s picture

This issue is active and needs some work. The feature is not implemented.

aspilicious’s picture

Issue summary: View changes

I'm not sure how we can move forward one this one...

  • swentel committed b97bc49 on 8.x-3.x authored by yannickoo
    Issue #1885262 by yannickoo: Added Allow unlimited items for ds node...