Active
Project:
Display Suite
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2013 at 14:51 UTC
Updated:
21 Oct 2016 at 20:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
yannickooComment #2
swentel commentedHmm, I guess why not, maybe we should update the description then as well that people can enter zero (or is a select box right now, don't know anymore) to have no limit.
Comment #3
yannickooI also thought about updating the description but what would be the description? Views is using "The number of items to display per page. Enter 0 for no limit.".
Oh, wrote wrong comment number ;)
Comment #4
yannickooComment #5
swentel commentedDon't worry about the number :)
Committed and pushed, thanks, moving to 8.x-2.x
Comment #6
yannickooThat was not a big deal :)
Comment #7
swentel commentedAlright, all in, thanks :)
Comment #8
swentel commentedWe might need to reroll this for the D8 version though, just spotted #702940: Add option 'Items per page' on admin/config/search/pages, we'll see what happens.
Comment #9
yannickooHey swentel, sorry for reopening but I had a problem with the "unlimited feature" and we don't remove the limit if we have unlimited values so we should only add the
->extend('PagerDefault');stuff if a limit was set. Otherwise it doesn't work :/Comment #10
swentel commentedGood call, committed and pushed.
Comment #11
swentel commentedSomething went completely wrong here, reopening
Comment #12
yannickooWhat do you mean with completely wrong?
Comment #13
swentel commentedErrors like this :
Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'SelectQuery' does not have a method 'limit' in SelectQueryExtender->__call() (line 840 of /Users/drupal/drupal7/includes/database/select.inc).
Comment #14
swentel commentedReverted for now - and also a new release
Comment #15
yannickooOh that is new to me. But now we have to remove the limit if
$limitis 0.Double semicolon ;)
Comment #16
yannickooSo here is a proper patch for the fix.
Comment #17
swentel commentedCommitted
Comment #18
aspilicious commentedI'm confused, whats the status of this issue?
Comment #19
yannickooThis issue is active and needs some work. The feature is not implemented.
Comment #20
aspilicious commentedI'm not sure how we can move forward one this one...