Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I think we should allow unlimited items for ds node search, what do you think?
Comment | File | Size | Author |
---|---|---|---|
#16 | ds-double_semicolon-1885262-16.patch | 708 bytes | yannickoo |
#14 | 1885262-revert-14.patch | 978 bytes | swentel |
#9 | ds-allow_unlimited_items_for_search-1885262-9.patch | 977 bytes | yannickoo |
#6 | ds-allow_unlimited_items_for_search-1885262-6.patch | 1.36 KB | yannickoo |
#4 | ds-allow_unlimited_items_for_search-1885262-4.patch | 1.32 KB | yannickoo |
Comments
Comment #1
yannickooComment #2
swentel CreditAttribution: swentel commentedHmm, I guess why not, maybe we should update the description then as well that people can enter zero (or is a select box right now, don't know anymore) to have no limit.
Comment #3
yannickooI also thought about updating the description but what would be the description? Views is using "The number of items to display per page. Enter 0 for no limit.".
Oh, wrote wrong comment number ;)
Comment #4
yannickooComment #5
swentel CreditAttribution: swentel commentedDon't worry about the number :)
Committed and pushed, thanks, moving to 8.x-2.x
Comment #6
yannickooThat was not a big deal :)
Comment #7
swentel CreditAttribution: swentel commentedAlright, all in, thanks :)
Comment #8
swentel CreditAttribution: swentel commentedWe might need to reroll this for the D8 version though, just spotted #702940: Make the number of results per page configurable, we'll see what happens.
Comment #9
yannickooHey swentel, sorry for reopening but I had a problem with the "unlimited feature" and we don't remove the limit if we have unlimited values so we should only add the
->extend('PagerDefault');
stuff if a limit was set. Otherwise it doesn't work :/Comment #10
swentel CreditAttribution: swentel commentedGood call, committed and pushed.
Comment #11
swentel CreditAttribution: swentel commentedSomething went completely wrong here, reopening
Comment #12
yannickooWhat do you mean with completely wrong?
Comment #13
swentel CreditAttribution: swentel commentedErrors like this :
Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'SelectQuery' does not have a method 'limit' in SelectQueryExtender->__call() (line 840 of /Users/drupal/drupal7/includes/database/select.inc).
Comment #14
swentel CreditAttribution: swentel commentedReverted for now - and also a new release
Comment #15
yannickooOh that is new to me. But now we have to remove the limit if
$limit
is 0.Double semicolon ;)
Comment #16
yannickooSo here is a proper patch for the fix.
Comment #17
swentel CreditAttribution: swentel commentedCommitted
Comment #18
aspilicious CreditAttribution: aspilicious commentedI'm confused, whats the status of this issue?
Comment #19
yannickooThis issue is active and needs some work. The feature is not implemented.
Comment #20
aspilicious CreditAttribution: aspilicious commentedI'm not sure how we can move forward one this one...