We have a situation in which the date repeat field isn't working for our client. There is already data in the field so we can create a new field or alter the current one easily. We opted to just disable the module but because our code is featurized, the site throws an error.

The following patch adds a condition to check and see if the date_repeat_field module is enabled before the form is built.

CommentFileSizeAuthor
#6 date-error-when-disable-date-repeat-field-1854220-6.patch874 bytesparavibe
#1 date_1854220_1.patch879 bytesryan.ryan

Comments

ryan.ryan’s picture

ryan.ryan commented
Status: Active » Needs review
StatusFileSize
new date_1854220_1.patch879 bytes

Status: Needs review » Needs work

The last submitted patch, date_1854220_1.patch, failed testing.

max-kuzomko’s picture

max-kuzomko commented
Assigned: Unassigned » max-kuzomko
Issue summary: View changes
max-kuzomko’s picture

max-kuzomko commented

Could somebody provide steps how to reproduce the issue?
Seems the issue is in 2.6 version but currently 2.8 version available.

max-kuzomko’s picture

max-kuzomko commented
Issue tags: +dcuacs2015
paravibe’s picture

paravibe commented
Version: 7.x-2.6 » 7.x-2.x-dev
Assigned: max-kuzomko » paravibe
Status: Needs work » Needs review
StatusFileSize
new date-error-when-disable-date-repeat-field-1854220-6.patch874 bytes

Steps to reproduce:

- Enable date_repeat_field module.
- Create a new field
- Set "Repeating date" to "Yes"
- Disable date_repeat_field module.
- Go to node/add/YOUR_CT page with previous created field.

Simple check if module exist does its job.

alex liannoy’s picture

alex liannoy commented

Looks pretty clear. +1 for RTBC

alex liannoy’s picture

alex liannoy commented
Status: Needs review » Reviewed & tested by the community

  • cafuego committed ed287f8 on 7.x-2.x authored by paravibe 
    Issue #1854220 by ryanissamson, paravibe: Add module_exists so that...
cafuego’s picture

cafuego commented
Status: Reviewed & tested by the community » Fixed

Applied, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.