Patch attached.

CommentFileSizeAuthor
#4 1845682-checkout-pane-styling.diff898 bytesaidanlis
untitled.diff662 bytesaidanlis

Comments

aidanlis’s picture

aidanlis commented
Status: Active » Needs review

This is a very quick patch with no repercussions ... would be great to get a review.

Status: Needs review » Needs work

The last submitted patch, untitled.diff, failed testing.

rszrama’s picture

rszrama commented

Not sure I understand the extra div - why not just make it a class of the wrapper? Additionally, classes should be passed through drupal_html_class().

aidanlis’s picture

aidanlis commented
Status: Needs work » Needs review
StatusFileSize
new 1845682-checkout-pane-styling.diff898 bytes

I think I had the extra div to fix an AJAX bug that's no longer present ... I've removed it and added the drupal_html_class. Thanks for reviewing!

Status: Needs review » Needs work

The last submitted patch, 1845682-checkout-pane-styling.diff, failed testing.

aidanlis’s picture

aidanlis commented
Status: Needs work » Needs review

Oh testbot

Status: Needs review » Needs work

The last submitted patch, 1845682-checkout-pane-styling.diff, failed testing.

aidanlis’s picture

aidanlis commented
Status: Needs work » Needs review
aidanlis’s picture

aidanlis commented

Ping!

chris matthews’s picture

chris matthews commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 6 year old patch in #4 to commerce_payment.checkout_pane.inc does not apply to the latest commerce 7.x-1.x-dev and (if still relevant) needs to be rerolled.