Make default.settings.php not executable [#1830330]

Comment	File	Size	Author
#11	1830330-1-core-default_settings_php_executable.patch	490 bytes	David_Rothstein

#4	1830330-4-core-file_permissions.do_not_test.patch	3.31 KB	pfrenssen

#1	1830330-1-core-default_settings_php_executable.patch	490 bytes	pfrenssen

Comment #2

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 2 November 2012 at 17:22

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

kotnik CreditAttribution: kotnik commented 2 November 2012 at 17:42

Status:

Needs review

» Needs work

While at it, could you also include these files which are executable for no reason:

./core/misc/ui/themes/base/images/ui-icons_222222_256x240.png
./core/misc/ui/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png
./core/misc/ui/themes/base/images/ui-bg_glass_75_dadada_1x400.png
./core/misc/ui/themes/base/images/ui-icons_888888_256x240.png
./core/misc/ui/themes/base/images/ui-bg_glass_65_ffffff_1x400.png
./core/misc/ui/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png
./core/misc/ui/themes/base/images/ui-icons_cd0a0a_256x240.png
./core/misc/ui/themes/base/images/ui-bg_glass_75_e6e6e6_1x400.png
./core/misc/ui/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png
./core/misc/ui/themes/base/images/ui-icons_2e83ff_256x240.png
./core/misc/ui/themes/base/images/ui-icons_454545_256x240.png

And maybe suffix patch with do-not-test since we know this won't affect tests in any way.

Log in or register to post comments

Comment #4

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 2 November 2012 at 18:39

Status:

Needs work

» Needs review

File	Size
1830330-4-core-file_permissions.do_not_test.patch	3.31 KB

Sure! I forgot to check if there were other files that had bad permissions, thanks!

Log in or register to post comments

Comment #5

kotnik CreditAttribution: kotnik commented 2 November 2012 at 18:51

Status:

Needs review

» Reviewed & tested by the community

Thanks. All good now.

Log in or register to post comments

Comment #6

2 November 2012 at 19:22

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 1830330-1-core-default_settings_php_executable.patch, failed testing.

Log in or register to post comments

Comment #7

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 2 November 2012 at 19:40

Status:

Needs work

» Needs review

#1: 1830330-1-core-default_settings_php_executable.patch queued for re-testing.

Log in or register to post comments

Comment #8

Anonymous (not verified) CreditAttribution: Anonymous commented 2 November 2012 at 19:53

Status:

Needs review

» Reviewed & tested by the community

Workflow timing; testbot came after the #5 status change.

Log in or register to post comments

Comment #9

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 2 November 2012 at 19:57

It will pop back once more, I have relaunched the test - I wonder what causes this to fail the bot.

Log in or register to post comments

Comment #10

David_Rothstein CreditAttribution: David_Rothstein commented 3 November 2012 at 15:46

Status:

Reviewed & tested by the community

» Needs work

Those other files are part of jQuery UI, not Drupal itself, so we shouldn't be changing them. If their permissions need to be changed it should be done upstream.

The original patch looks good, though. This has been annoying me for a while since I have an installation script that tends to reset file permissions inside sites/default (which then causes a diff to appear on this file), but I never got around to filing an issue :)