Will be good have the option:

  1. 1- Label wrapper on the Field themplate -> expert

For example In some case have to put a <div> to give some style around at <a> and both have different class and atributes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

Status: Active » Needs review
FileSize
5.33 KB

Patch

alanburke’s picture

Status: Needs review » Needs work
FileSize
45.57 KB
98.41 KB

Cool.
But not quite there.
The Wrapper is inside the label.
Screenshots of config and output attached.

alanburke’s picture

Assigned: carajito » Unassigned
Status: Needs work » Needs review
FileSize
5.37 KB

Attempted fix attached

aspilicious’s picture

I'm not a themer so i'm kind confused, what should be the desired output? Inside or outside the label? Carajito can you tell use?

alanburke’s picture

I just expected the wrapper to be on the outside - I'd consider the expected behaviour.
All other DS options are for wrapping the basic content, with the wrappers your require,
so this would be consistent.

aspilicious’s picture

Ok I'm fine with this. I'm going to commit this when I've tested it properly to ensure it doesn't brake anything.
Can take a week :)

aspilicious’s picture

Issue tags: +sprint-nascom-2013

Sprint material

aspilicious’s picture

Issue summary: View changes
Status: Needs review » Fixed

Committed this finally.
Thnx!

aspilicious’s picture

Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Fixed » Patch (to be ported)
borisson_’s picture

I did some work on porting this to d8

aspilicious’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.