By not doing so, the filter prevents users from viewing content that they should be able to view on a site with no additional node access modules installed beyond core.

The attached patch checks for

module_implements('node_grants')

, as Core does in node_access().

Files: 
CommentFileSizeAuthor
#1 core-1822440-1.patch737 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 46,224 pass(es). View
views-content-access-node-grants.patch712 bytesezra-g
PASSED: [[SimpleTest]]: [MySQL] 1,603 pass(es). View

Comments

dawehner’s picture

Project: Views » Drupal core
Version: 7.x-3.x-dev » 8.x-dev
Component: Code » node.module
Issue tags: +VDC
FileSize
737 bytes
PASSED: [[SimpleTest]]: [MySQL] 46,224 pass(es). View

This looks great.

I'm not sure what the proper way of getting patches from contrib to core would be, but i think for really simple patches it might make sense to forward-port them.

smiro’s picture

this applies cleanly, honestly not sure how to test what approach might be better ;)

jibran’s picture

Issue tags: +Needs tests

It is a bug it needs some test to show the bug.

jibran’s picture

Status: Needs review » Needs work

As per #3.

xjm’s picture

Component: node.module » node system
Issue summary: View changes

(Merging "node system" and "node.module" components for 8.x; disregard.)

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.