Problem/Motivation

Several Drupal theme functions result in exactly the same markup structures. As we convert to twig we should take the opportunity to consolidate what can be consolidated, and add theme_hook suggestions where particular instances of these structures may need to be overridden independently.

Proposed resolution

Implement theme('table') wherever possible, and add theme_hook_suggestions for all variations, including:

Remaining tasks

User interface changes

None.

API changes

Removal of the following theme functions:

#1804614: [meta] Consolidate theme functions and properly use theme suggestions in core

Comments

jenlampton’s picture

Title: Use theme_table instead of theme_forum_list? » Update all table theme functions to use theme_table instead

updating title

jenlampton’s picture

Issue summary: View changes

added theme_tableselect too

jenlampton’s picture

Component: forum.module » theme system

updating component too :)

aspilicious’s picture

Don't forget the custom views table function ;)

aspilicious’s picture

Issue summary: View changes

reformat

jenlampton’s picture

Issue summary: View changes

add image style list

jenlampton’s picture

Title: Update all table theme functions to use theme_table instead » [meta] Update all table theme functions to use theme_table instead

updating title. and yes, we'll need to get views to use our default components as well. :)

jenlampton’s picture

Title: [meta] Update all table theme functions to use theme_table instead » [meta] Consolidate all table templates and add theme_hook_suggestions
Assigned: Unassigned » jenlampton

updating title, again

jenlampton’s picture

Issue summary: View changes

clearer explanation of table consolidation

jenlampton’s picture

Issue summary: View changes

summary

jenlampton’s picture

Issue summary: View changes

update

sun’s picture

Please note that #1876712: [meta] Convert all tables in core to new #type 'table' will eliminate a couple of these.

sun’s picture

Issue summary: View changes

add image_style_effects

jenlampton’s picture

Issue tags: +Template consolidation
jenlampton’s picture

Issue summary: View changes

added theme admin book table

jenlampton’s picture

Issue summary: View changes

issue cleanup

jenlampton’s picture

Issue summary: View changes

links to more issues

jenlampton’s picture

Issue summary: View changes

create issues for each template removal

mitokens’s picture

akalata’s picture

Assigned: jenlampton » Unassigned
Status: Active » Closed (fixed)

Since all tasks are completed, this can be closed, right?