Closed (fixed)
Project:
Panels
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2012 at 20:45 UTC
Updated:
16 Jun 2014 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
populist commentedI did more research and believe the problem we introduced with #1772834: Panels IPE Save Drops Context Specified in Page Manager was that the context caching system was dependant on a key that provided the arguments. This has trouble with you have placeholder arguments (i.e. node edit pages) and needs a more global context call to capture all of the arguments.
This patch switches up the caching logic so that conditionally loads the contexts appropriate for arguments, but if there are no arguments present it will load all arguments. It solves the problem with the node_edit handler *not* having the right context AND it allows things like the search page to maintain context with the IPE.
Comment #2
merlinofchaos commentedThe patch in #1 would not add contexts that were added as part of the handler, which only shows up if you add relationships or the like in the handler on places like the node edit page that doesn't have its own contexts tab. I added that back in and after spending some time trying to decide if this was really the right approach, I went ahead with it.