The layout looks messy with formats and comment notify enabled. See attached.

CommentFileSizeAuthor
#10 Capture d’écran 2013-07-10 à 12.00.18.png40.37 KBCookiz
#9 Skærmbillede 2013-04-20 kl. 14.28.15.png48.86 KBlsolesen
#5 Before22.63 KBlsolesen
#5 After21.84 KBlsolesen
#4 commentradios-1788168-4.patch3.85 KBdudenhofer
#4 Comments-Style-Update.png44.41 KBdudenhofer
Skærmbillede 2012-09-18 kl. 20.18.45.png43.79 KBlsolesen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller commented
Title: Messy layout with comment notify enabled » Front end theme not ready for radio button labels.
Priority: Normal » Minor

Our front end theme needs to handle radio buttons with labels.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Assigned: Unassigned » dudenhofer

Shouldn't be too hard to fix.

dudenhofer’s picture

dudenhofer CreditAttribution: dudenhofer commented
Project: Commerce Kickstart » Omega Kickstart
Version: 7.x-2.0-rc1 » 7.x-3.x-dev

This issue reached down into the Omega Kickstart theme, so I'm reassigning this to that Issue que. I have the patch coming shortly.

dudenhofer’s picture

dudenhofer CreditAttribution: dudenhofer commented
Status: Active » Needs review
FileSize
Comments-Style-Update.png44.41 KB
commentradios-1788168-4.patch3.85 KB

Attaching the patch for fixing the radio/checkboxes. I'm also attaching a screenshot of how it should look after my patch is applied.

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Status: Needs review » Needs work
FileSize
After21.84 KB
Before22.63 KB

There is a small improvement, but comment notify still looks messy after the patch has been applied.

dudenhofer’s picture

dudenhofer CreditAttribution: dudenhofer commented

Are you sure the patch applied cleanly? Your screenshots don't show any difference as far as what the patch should have fixed.. I thought maybe the patch was too aged to still work, but I just applied it on a fresh Kickstart install and it seemed to work as expected.

Cookiz’s picture

Cookiz CreditAttribution: Cookiz commented
Status: Needs work » Fixed

Fixed in the last dev version, I reused dudenhofer's patch and adapt it to the current css.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Status: Closed (fixed) » Active
FileSize
Skærmbillede 2013-04-20 kl. 14.28.15.png48.86 KB

I am pretty sure, that the issue still remains. Using the latest kickstart 2.6 and added comment_notify and this is how it looks in the comments.

Cookiz’s picture

Cookiz CreditAttribution: Cookiz commented
Assigned: dudenhofer » Unassigned
Status: Active » Fixed
FileSize
Capture d’écran 2013-07-10 à 12.00.18.png40.37 KB

Fixed in the last dev release, a new release of omega_kickstart should happen soon.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.