Menu Path Autocomplete can make creating redirects a lot more convenient. Just try it ;) (read: I'm too lazy to write a long justification)

A patch is on its way.

CommentFileSizeAuthor
#1 redirect-Use_autocomplete_if_Menu_Path_Autocomplete_is_available-1768530-1.patch1.45 KBDrave Robber

Comments

Drave Robber’s picture

Drave Robber commented
Assigned: Drave Robber » Unassigned
Status: Active » Needs review
StatusFileSize
new redirect-Use_autocomplete_if_Menu_Path_Autocomplete_is_available-1768530-1.patch1.45 KB

Here it is.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Title: Use autocomplete if Menu Path Autocomplete is available » Use autocomplete if Menu Path Autocomplete is available (and list it in the "Recommended Modules" section on the project page).

;)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue summary: View changes
Parent issue: » #2514248: Plan for Redirect v7.x-1.0 release
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work
Parent issue: #2514248: Plan for Redirect v7.x-1.0 release »

Hrm, instead of having redirect implement a hook on behalf of mpac, I would be ok with adding a conditional in redirect_edit_form() itself using module_exists('mpac').

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Committed to 7.x-2.x and 7.x-1.x.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I backtracked and like the hook instead of conditional module_exists() in redirect_edit_form().

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

Still missing the "and list it in the "Recommended Modules" section on the project page" part of th issue.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It has been added to the project page.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Use autocomplete if Menu Path Autocomplete is available (and list it in the "Recommended Modules" section on the project page). » Use autocomplete if Multi-path autocomplete (mpac.module) is available (and list it in the "Recommended Modules" section on the project page).

Correcting title to use the correct module name.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jacob.embree’s picture

jacob.embree commented

Dave, I'm curious what changed your mind. Do you mind explaining the pros and cons you see of hook vs. conditional?