Anecdotally, both from personal experience and seeing many developers get tripped up by this, most developers do not need per-field timezone handling to be enabled and it turns into a major snafu when they realize the mistake; convention-over-configuration then suggests that the date field setting for timezone handling should default to "No time zone conversion" rather than "Site's time zone".

CommentFileSizeAuthor
#15 date-n1762120-15.patch3.77 KBDamienMcKenna
#14 date-n1762120-14.patch1.53 KBDamienMcKenna
#8 date-n1762120-8.patch3.93 KBDamienMcKenna
#8 date-n1762120-new.png80.85 KBDamienMcKenna
#8 date-n1762120-old.png80.24 KBDamienMcKenna
#1 date-n1762120-d7.patch3.96 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
date-n1762120-d7.patch3.96 KB

This patch changes all defaults from using 'site' to 'none', i.e. from adjusting to the site's timezone settings to ignoring timezone conversion altogether.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Status: Needs review » Needs work

The last submitted patch, date-n1762120-d7.patch, failed testing.

wusel’s picture

wusel CreditAttribution: wusel commented

I agree to the Issue Summary.
Look at http://drupal.org/node/1477602#note1

bojanz’s picture

bojanz CreditAttribution: bojanz commented

+1
This tripped me up as well.

nasrani’s picture

nasrani CreditAttribution: nasrani commented
Issue summary: View changes
Status: Needs work » Closed (cannot reproduce)

Hi @DamienMcKenna and @bojanz,

The Time zone handling which I can currently see is "No time zone conversion".

If you still face the issue, please feel free to open it again,

So, as of now, marking it as Closed (cannot reproduce)

Thank you,
Nikhil Asrani.

Status: Closed (cannot reproduce) » Needs review

DamienMcKenna queued 1: date-n1762120-d7.patch for re-testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
date-n1762120-old.png80.24 KB
date-n1762120-new.png80.85 KB
date-n1762120-8.patch3.93 KB

This is how the current -dev version looks:
Old

This is how it looks with the patch applied:
New

I've rerolled the patch.

Status: Needs review » Needs work

The last submitted patch, 8: date-n1762120-8.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Note - the 7.x-2.x branch has a TON of errors right now, so the test failures are not an accurate representation of the patch's stability.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Needs rework

The 3 year old patch in #8 does not apply to the latest 7.x-2.x-dev and may be too old to reroll, but I went ahead and tagged the issue accordingly.

Checking patch date.field.inc...
Hunk #1 succeeded at 241 (offset -5 lines).
Checking patch date_migrate/date_migrate_example/date_migrate_example.features.field.inc...
Checking patch date_tools/tests/date_tools.test...
error: while searching for:
      'todate' => 'optional',
      'field_type' => 'date',
      'granularity[]' => array('year', 'month', 'day', 'hour', 'minute'),
      'tz_handling' => 'site',
      'year_range' => '2010:+2',
    );
    $this->drupalPost('admin/config/date/tools/date_wizard', $edit, t('Save'));

error: patch failed: date_tools/tests/date_tools.test:95
error: date_tools/tests/date_tools.test: patch does not apply
Checking patch date_views/date_views.module...
Hunk #1 succeeded at 228 (offset 5 lines).
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: -
Parent issue: » #3241397: Plan for Date 7.x-2.13
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
date-n1762120-14.patch1.53 KB

Rerolled.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
date-n1762120-15.patch3.77 KB

Missed a change in the reroll.

Status: Needs review » Needs work

The last submitted patch, 15: date-n1762120-15.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review

So let's just go with the UI change and skip the changes to the included feature.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: -Needs reroll +Needs change record

This will need a change record.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Issue tags: -Needs change record

Committed.

  • DamienMcKenna committed 35bb427 on 7.x-2.x 
    Issue #1762120 by DamienMcKenna: Change field timezone handling default...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.