I'm getting this error:

Notice: Undefined property: apachesolr_views_query::$group_operator in apachesolr_views_query->execute() (line 83 of /Applications/MAMP/htdocs/sandbox/docroot/sites/all/modules/apachesolr_views/apachesolr_views_query.inc).

Also, I noticed that on line 30, there are a couple of minor documentation errors:
* Neede for grouppin of query conditions.
should probably be:
* Needed for grouping of query conditions.

CommentFileSizeAuthor
#1 set_group_operator-1761432-1.patch457 bytestheapi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

theapi’s picture

theapi CreditAttribution: theapi commented
FileSize
set_group_operator-1761432-1.patch457 bytes

Here's a patch to set the default group_operator value and stop the php warning.

views_plugin_query (the class that is extended by apachesolr_views_query) has the function set_group_operator() but no default for the variable.

heaths1’s picture

heaths1 CreditAttribution: heaths1 commented

Novice input: Applied #1 and the warning went away, but not smart enough to know if there was any other impact.

Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Active » Reviewed & tested by the community

Works fine for me. Thanks PeterC!

GaxZE’s picture

GaxZE CreditAttribution: GaxZE commented

Works for me too.

Nice one.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate commented
Status: Reviewed & tested by the community » Needs review

Thanks for testing everyone. Setting this to 'needs review' so that the Drupal.org testbot will pick it up and test it. If it passes, then we should set this back to RTBC, right? Cheers, Jeff

Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber commented
Status: Needs review » Reviewed & tested by the community

by now this module cannot be tested by the test bot

Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber commented
Issue summary: View changes

minor spelling error

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented

Works on my end. +1 to commit this.

budda’s picture

budda
Primary language English
Location Cheshire
CreditAttribution: budda commented
Issue summary: View changes

Is there any reason why this 1 line variable declaration can't be committed to the dev branch ready for a new release ? It's been over two years since the patch was submitted and tested by the community.

rutiolma’s picture

rutiolma
Location 🇵🇹
CreditAttribution: rutiolma commented

This patch should be commited.

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.